fix injectors for sourcemapped code

2gis / slot

JavaScript фреймворк, позволяющий быстро и просто создавать модульные изоморфные приложения.

http://2gis.github.io/slot

BSD 2-Clause "Simplified" License

86 stars 10 forks source link

fix injectors for sourcemapped code #239

Closed ctizen closed 8 years ago

ctizen commented 8 years ago

We should add DI annotations before any sourcemaps. or annotations will be considered as a part of sourcemap and will be cut in downstream. Pretty ugly hack, but should not break anything.

ctizen commented 8 years ago

@fobos @ovvost

fobos commented 8 years ago

Need to discuss tomorrow morning

fobos commented 8 years ago

:+1: Looks weird

ovvost commented 8 years ago

:+1:

lastw commented 8 years ago

million dollar idea: make uglify to keep components' variables not mangled with regex (mangle-regex option in uglify2)

/cc @artem-malko

ctizen commented 8 years ago

worth trying.

ctizen commented 8 years ago

I've played around with mangle-regex for a while and didn't find the way to disable mangling of function argument names. Gonna merge current solution.