search

2graphic / sinap-ide

Sinap IDE development project.
7 stars 1 forks source link

Should we disable CRLF->LF in formatter? #361

Open slaymaker1907 opened 7 years ago

slaymaker1907 commented 7 years ago

If you have git setup on Windows to convert LF to CRLF, running format creates a huge diff even though nothing really changed. If we set tsfmt to not change the line endings, then that will make it simpler here but could make us end up with a bunch of bad line endings.

I'm wondering if we could configure our git repo to automatically do the conversion and not worry about it in tsmft?

cj-dimaano commented 7 years ago

I think if we can get GitHub to enforce LF over CRLF, then I'm for getting rid of the tsfmt rule. However, I believe the configuration of the git tool on Windows depends on the user, but I'm not too sure.