search

2graphic / sinap-ide

Sinap IDE development project.
7 stars 1 forks source link

UglifyJS does not like `const` #363

Open cj-dimaano opened 7 years ago

cj-dimaano commented 7 years ago

UglifyJS keeps throwing an error when trying to npm run build:prod. Try this on the linux-package-manager branch; it keeps throwing an error on main.js and modal.js.

Tested on node 7.10 and npm 4.5.

cj-dimaano commented 7 years ago

364 temporary fix.

slaymaker1907 commented 7 years ago

As I stated on an earlier PR I don't think that UglifyJS really provides any benefit anyway since it has only a minimal effect on our bundle size.

cj-dimaano commented 7 years ago

I'm not arguing against you. It might be nice to have or something like it in the future.

On May 11, 2017 1:29 PM, "slaymaker1907" notifications@github.com wrote:

As I stated on an earlier PR I don't think that UglifyJS really provides any benefit anyway since it has only a minimal effect on our bundle size.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/2graphic/sinap-ide/issues/363#issuecomment-300892956, or mute the thread https://github.com/notifications/unsubscribe-auth/AVV1vAUEW2siHgud48u_O7-SKJaYyl6-ks5r42F_gaJpZM4NTSAg .