Closed consideRatio closed 1 year ago
@GeorgianaElena I think this is good to go finally, its quite a messy PR because it introduced dockerApi.extraFiles for example, but that is copy-pasted from z2jh where it has been very successfully used reliably to inject files into pods.
I suggest we go for a merge and iterating from there with fixes if needed.
Thanks @consideRatio!
With binderhub-service being a Helm chart deploying to k8s, we absolutely require the ability to push the built artifact to a container registry somewhere. This enables the chart to create a k8s Secret with such credentials in a docker config format that can be mounted to the build pods via
c.KubernetesBuildExecutor.push_secret
. Users of the binderhub-service chart doesn't have to configure that manually, its instead set automatically.buildPodsRegistryCredentials
buildPodsRegistryCredentials
should be provided withserver
,username
, andpassword
for the container registry. For a GCP based artifact-registry, this can be for example...buildPodsDockerConfig
This may not be relevant for us to use, but was added for parity with binderhub chart to some degree.
dockerApi.[extraArgs|extraFiles]
In order to setup tests with build/push, I needed to configure the docker daemon runnin on the host node to tolerate interacting with HTTP based docker registries like the one we have. Instead of doing like in jupyterhub/binderhub where a configmap is created and mounted etc in a way that is very hard to follow, I do something that is just quite hard to follow by introducing
extraFiles
taken from z2jh.Tests build/push