search

2i2c-org / binderhub-service

https://2i2c.org/binderhub-service/
BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

bugfix: add docker config secret to the deployment to be mounted #48

Closed GeorgianaElena closed 1 year ago

GeorgianaElena commented 1 year ago

Follow-up to #36

consideRatio commented 1 year ago

@GeorgianaElena the secret is mounted to the build pods that are dynamically created by binderhub by configuring KubeBuildExecutoe.push_secret (or something like that) somewhere in the binderhub config.

It has been a journey to understand this for me - config could be relevant in the pod where binderhub runs, the build pods it create, or on the daemonset pods providing a docker api for the build pods to use. It turns out, its relevant to the place where a docker client runs specificially, so only the build pods need this info i think

GeorgianaElena commented 1 year ago

Makes sense. Thank you @consideRatio!