search

2i2c-org / binderhub-service

https://2i2c.org/binderhub-service/
BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Create a fork of binderhub to develop opt-out feature of not launching following build/push #6

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

Update

Fork and development branch, together with a draft PR is now found at https://github.com/jupyterhub/binderhub/pull/1647.

yuvipanda commented 1 year ago

Can you tell me what you mean by a 'fork' in this context?

consideRatio commented 1 year ago

I mean a github repository fork of jupyterhub/binderhub to develop and trial the feature to upstream to jupyterhub/binderhub after success.

yuvipanda commented 1 year ago

I would love for us to have a WIP PR on the binderhub repo from the start, primarily to make sure we don't end up writing code that is not acceptable to be merged. The smaller the diffs, the better. However, we do not need to wait for those to first get merged before continuing testing.

For this specifically, I would suggest a traitlet that adds a conditional to not launch.

consideRatio commented 1 year ago

We are in agreement on the importance of getting feedback on the proposed change as quick as possible!

I ended up formulating this as a goal as I want to ensure that I can build the Dockerfile referencing a fork's branch meanwhile waiting for feedback and approval of the upstream PR.

consideRatio commented 1 year ago

I've opened https://github.com/jupyterhub/binderhub/pull/1647 as a placeholder PR, and used my personal repo consideratio/binderhub as a fork - but the PR branch can be pushed to by jupyterhub/binderhub maintainers.

This is what's relevant to facilitate Dockerfile creation etc to unblock https://github.com/2i2c-org/binderhub-service/issues/3.