2i2c-org / infrastructure

Infrastructure for configuring and deploying our community JupyterHubs.
https://infrastructure.2i2c.org
BSD 3-Clause "New" or "Revised" License
108 stars 65 forks source link

deployer: health check can fail to detect failing startup #3777

Closed consideRatio closed 1 week ago

consideRatio commented 9 months ago

In #3776 I saw that the health check passed, but manually testing to launch a server failed. I assume the difference is that we check that the pod enters a running state or similar, but for the user server to successfully start - also JupyterHub needs to believe its successfully started, and that isn't something we check for currently.

Action points

consideRatio commented 1 week ago

I think this could have been due to a kubespawner bug fixed in kubespawner 7, available in z2jh 4, so I propose ignoring this and relying on getting z2jh 4 (see #5079 )