search

2i2c-org / infrastructure

Infrastructure for configuring and deploying our community JupyterHubs.
https://infrastructure.2i2c.org
BSD 3-Clause "New" or "Revised" License
103 stars 57 forks source link

Can not use tolerations with a particular profileList item #4245

Open jmunroe opened 1 month ago

jmunroe commented 1 month ago

I was following https://infrastructure.2i2c.org/howto/features/dedicated-nodepool/#gcp to add new node pool for use in unam.latam.catalystproject.2i2c.cloud .

The instructions say to add

jupyterhub:
  singleuser:
    nodeSelector:
      2i2c.org/community: <community-name>
    extraTolerations:
      - key: 2i2c.org/community
        operator: Equal
        value: <community-name>
        effect: NoSchedule

but that hub uses a ProfileList. Since the traitlet tolerations is a list, setting it here would unset the default tolerations set by z2jh, and thus the pod won't be able to schedule.

Temporarily, extraTolerations is fine as having additional tolerations on the pod is not a big deal. But eventually we should figure out how this can work.

yuvipanda commented 1 month ago

Thank @jmunroe. I've edited to add a few details based on our meeting.