aws terraform: try to ensure tags for new projects are applied to all our resources created via terraform

[consideRatio]

Ideally, this is done before we create the next AWS cluster and hubs for nmfs-openscapes in #4696 - the tags are meant to help attribute costs.

I've already concluded it seems that buckets aren't tagged with 2i2c:hub-name tags yet for example, and that is tracked by #4710.

Wanted tags

• For all AWS resources we create via terraform, we want to have the ManagedBy=2i2c tag applied.
• For all AWS resources associated with a hub we create via terraform, we want to have the 2i2c:hub-name=<hub name == namespace name> tag applied

Practical guidance

• It seems that earthscope is quite recently created, and for example should have ManagedBy=2i2c set on all created resources. Does it? Does it have 2i2c:hub-name=<name> on resources tied/owned by a specific hub?

Definition of done

• [ ] You done a pass of checking in terraform and various clusters AWS consoles if resources we create via terraform gets tagged with wanted tags in new projects.
• [ ] You have either directly fixed any failures to apply wanted tags to resources for new hubs, or opened and refined followup issues to this.
  • Note that #4710 is already opened

[yuvipanda]

During the sprint planning meeting yesterday, we decided that this shouldn't block new cluster creation.

Let's work out the issues within openscapes first, and not complicate new cluster creation until we're sure what needs to happen.

[consideRatio]

With #4742, motivated by strategy decided on working #4712 and #4713 I think things are sufficiently tagged to do cost allocations well for openscapes and new clusters - closing as sufficiently completed.