search

2i2c-org / infrastructure

Infrastructure for configuring and deploying our community JupyterHubs.
https://infrastructure.2i2c.org
BSD 3-Clause "New" or "Revised" License
106 stars 65 forks source link

Round 1: Strategic upstream OSS support by reviewing non-maintainer PRs #5058

Open yuvipanda opened 1 week ago

yuvipanda commented 1 week ago

This issue tracks one round of doing strategic upstream work by reviewing PRs (see https://github.com/2i2c-org/meta/issues/1289#issuecomment-2443211503) from non-maintainers in the communities we care about. The primary goals here are:

  1. Shake out our process for integrating this into our regular planning, so everyone in the team can participate
  2. Provide a place to track what work we are actually doing
  3. Build capacity within our team for doing code review consistently and equitably

Round 1 should continue until the end of January, where we can evaluate the results.

Process

WIP process that will be modified as we go.

  1. We create a subissue of this issue for each PR we want to review
  2. Created subissue gets tracked as a task in P&S sprint planning
agoose77 commented 3 days ago

@sgibson91 and I took a look at jupyterhub/nbgitpuller#359 (#5059).

Overall the PR is indeed simple, and looks correct. We clarified the issue cause, and identified that the suggested PR was a suitable fix. We made a suggestion about future improvements to this work.

We noticed that there is a range of experience in the team. We reflected that this was therefore a good opportunity not only to contribute to OSS, but also to become more familiar with keystone projects in the ecosystem, and in particular, to undertake some peer mentoring in order to narrow the range of experience and skills.

On that note, @agoose77 originally suggested a 30m meeting. This was overly optimistic, and didn't facilitate a good opportunity for peer mentoring.

From @agoose77, thanks @sgibson91 for pairing!