Review https://github.com/jupyterhub/nbgitpuller/pull/359 - Githubissues

2i2c-org / infrastructure

Infrastructure for configuring and deploying our community JupyterHubs.

https://infrastructure.2i2c.org

BSD 3-Clause "New" or "Revised" License

106 stars 65 forks source link

Review https://github.com/jupyterhub/nbgitpuller/pull/359 #5059

Closed yuvipanda closed 3 days ago

yuvipanda commented 1 week ago

https://github.com/jupyterhub/nbgitpuller/pull/359 has been sitting for a bit, and it would be a great way to jump start our structured upstream OSS contribution process. It's a simple start because:

There's a clear bug report of a specific problem
The PR has a clear and veriiable fix that is possible to test

Suggested Steps

These are purely suggested steps, and need not be followed. Our goal is to see if this PR improves the project, and

Setup a local dev environment of nbgitpuller
Validate the error reported in https://github.com/jupyterhub/nbgitpuller/issues/358
Pull https://github.com/jupyterhub/nbgitpuller/pull/359 and test to see if that fixes the issue
??? We have to figure it out from here collectively :) Use your best judgement and ask questions!

Definition of done

[x] The PR had been responded to in some way
[x] We write down what we learnt from this process in https://github.com/2i2c-org/infrastructure/issues/5058

sgibson91 commented 3 days ago

@agoose77 and I completed this today