Closed shberlin closed 4 months ago
Furthermore, the icon_path is ignored.
The dictionary item does not get the icon_url. Therefore line
icon_url = ujoin(self.base_url, 'launcher-shortcuts', 'icon', sp.name)
needs to be replaced with
icon_url = ujoin(self.base_url, 'launcher-shortcuts', 'icon', ls.name)
item['icon_url'] = icon_url
Should now be resolved by https://github.com/2i2c-org/jupyter-launcher-shortcuts/pull/23!
@shberlin great bug report writeup btw!! :heart: :tada:
Hello @yuvipanda ,
Thanks for this nice package. Unfortunately I cannot insert a svg icon.
I have used the following versions of your package and extension.
As soon as I use the icon_path argument in jupyter_notebook_config.py , an error is raised (without it works fine).
The logs give me the following error:
So the following line is buggy:
In the history I see that @bsimpson53 has fixed this on 31 May 2020 commenting 'bad var name '.
This change does not seem to have made it into the final package.