search

2kpr / ComfyUI-PMRF

GNU Affero General Public License v3.0
55 stars 2 forks source link

Please do not pin dependency versions when using pip #1

Open hben35096 opened 1 week ago

hben35096 commented 1 week ago

torchvision 0.18.1 no problem If it is 0.19.0, it must be torch>=2.4.0 realesrgan 0.3.0 It's no problem

Torch 2.3.1 works fine with installing natten==0.17.1 as well. It is not necessary to use pip3 install natten==0.17.1+torch230cu121 -f https://shi-labs.com/natten/wheels/, as this would force the installation of Torch 2.3.0, causing a series of issues. If you want to keep the existing Torch version, you can download natten from https://shi-labs.com/natten/wheels/. To use a plugin, forcibly changing the entire ComfyUI runtime environment is not advisable.

2kpr commented 1 week ago

Concerning torchvision, I was just working off of the PMRF HF demo: https://huggingface.co/spaces/ohayonguy/PMRF/blob/main/requirements.txt , and I just used their value as a reference but I'm also not pinning the versions with "==", but am using ">=": https://github.com/2kpr/ComfyUI-PMRF/blob/main/prestartup_script.py#L55

And concerning the natten installs, I already do check for what version of cuda and torch the user has and adjust the pip install for natten dynamically: https://github.com/2kpr/ComfyUI-PMRF/blob/main/prestartup_script.py#L172 , so I already account for their cuda and torch versions such that their ComfyUI environment isn't modified when install natten.