2lambda123 / -mi-sdm439-android_device_xiaomi_mi439

0 stars 0 forks source link

mi439: Drop pine from assert devices #2

Closed 2lambda123 closed 4 months ago

2lambda123 commented 4 months ago

• As required by PixelExperience CoC (Code of Conduct), 2gb ram devices are not allowed. So drop pine, pine users can still flash it by adding pine in assert line while flashing.

Description

Related Issue

Types of changes

Checklist:

performance-testing-bot[bot] commented 4 months ago

Unable to locate .performanceTestingBot config file

cr-gpt[bot] commented 4 months ago

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

code-companion-ai[bot] commented 4 months ago

Processing PR updates...

codesyncapp[bot] commented 4 months ago

Check out the playback for this Pull Request here.

git-greetings[bot] commented 4 months ago

Thanks @2lambda123 for opening this PR!

For COLLABORATOR only :

sweep-ai[bot] commented 4 months ago

Sweep: PR Review

BoardConfig.mk

The change removes the "pine" device identifier from the list of devices that the OTA update will assert compatibility with.

Sweep Found These Issues

  • Removing the "pine" device identifier from the TARGET_OTA_ASSERT_DEVICE list will exclude the "pine" device from receiving OTA updates.
  • https://github.com/2lambda123/-mi-sdm439-android_device_xiaomi_mi439/blob/49a25c4f459b4e3a3e25b0764abbb5b44391ac45/BoardConfig.mk#L13 [View Diff](https://github.com/2lambda123/-mi-sdm439-android_device_xiaomi_mi439/pull/2/files#diff-151aef4e286613b79b65e512509f8c5b43c20939baff4c9e65e38ab639e0e7a5R13)

quine-bot[bot] commented 4 months ago

👋 Figuring out if a PR is useful is hard, hopefully this will help.

  • @2lambda123 has been on GitHub since 2019 and in that time has had 2216 public PRs merged
  • Don't you recognize them? They've been here before 🎉
  • Here's a good example of their work: HeyGenClone
  • From looking at their profile, they seem to be good with Shell and HTML.

Their most recently public accepted PR is: https://github.com/2lambda123/-mi-sdm439-android_device_xiaomi_mi439/pull/1

git-greetings[bot] commented 4 months ago
PR Details of @2lambda123 in -mi-sdm439-android_device_xiaomi_mi439 : OPEN CLOSED TOTAL
1 1 2
codeautopilot[bot] commented 4 months ago

undefined

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate Limit Exceeded

@2lambda123 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 17 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 245e2ae8399cbb9e31de1e15163ce68e73324672 and 49a25c4f459b4e3a3e25b0764abbb5b44391ac45.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.