Closed 2lambda123 closed 3 months ago
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information
Thanks @2lambda123 for opening this PR!
For COLLABORATOR only :
To add labels, comment on the issue
/label add label1,label2,label3
To remove labels, comment on the issue
/label remove label1,label2,label3
Unable to locate .performanceTestingBot config file
A "Cancel" button was added to the "New Variable" dialog to allow users to close the modal without adding a new variable.
Sweep Found These Issues
this.modal('hide')
, which may not correctly reference the modal instance, potentially causing the button to fail to close the modal.Processing PR updates...
The recent update to the nf-variable-registry.js
file introduces a new "Cancel" button configuration. This enhancement includes setting specific colors for the button and implementing a click handler to hide a modal, improving user experience and interface control.
File Path | Change Summary |
---|---|
.../nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/... |
Added a "Cancel" button with color settings and a click handler to hide a modal in nf-variable-registry.js . |
In the code a button gleams, A "Cancel" click to end our dreams. With colors bright and handlers tight, It hides the modal out of sight. 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
👋 Figuring out if a PR is useful is hard, hopefully this will help.
- @2lambda123 has been on GitHub since 2019 and in that time has had 2217 public PRs merged
- They haven't contributed to this repo before
- Here's a good example of their work: HeyGenClone
- From looking at their profile, they seem to be good with Shell and Makefile.
Their most recently public accepted PR is: https://github.com/2lambda123/-mi-sdm439-android_device_xiaomi_mi439/pull/2
First PR by @2lambda123
PR Details of @2lambda123 in NorthropGrumman-nifi : | OPEN | CLOSED | TOTAL |
---|---|---|---|
1 | 0 | 1 |
undefined
Check out the playback for this Pull Request here.
This closes NIFI-6603
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[ ] Has your PR been rebased against the latest commit within the target branch (typically
master
)?[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
Summary by CodeRabbit