2lambda123 / NorthropGrumman-nifi

Apache License 2.0
0 stars 0 forks source link

Add cancel button to variable name creation dialog #1

Closed 2lambda123 closed 3 months ago

2lambda123 commented 3 months ago

This closes NIFI-6603

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

For code changes:

For documentation related changes:

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Summary by CodeRabbit

cr-gpt[bot] commented 3 months ago

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

git-greetings[bot] commented 3 months ago

Thanks @2lambda123 for opening this PR!

For COLLABORATOR only :

performance-testing-bot[bot] commented 3 months ago

Unable to locate .performanceTestingBot config file

sweep-ai[bot] commented 3 months ago

Sweep: PR Review

nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-variable-registry.js

A "Cancel" button was added to the "New Variable" dialog to allow users to close the modal without adding a new variable.

Sweep Found These Issues

  • The click handler for the "Cancel" button uses this.modal('hide'), which may not correctly reference the modal instance, potentially causing the button to fail to close the modal.
  • https://github.com/2lambda123/NorthropGrumman-nifi/blob/3cc311c02102d9ce28d505e675cb1cca5911e5cd/nifi-nar-bundles%2Fnifi-framework-bundle%2Fnifi-framework%2Fnifi-web%2Fnifi-web-ui%2Fsrc%2Fmain%2Fwebapp%2Fjs%2Fnf%2Fcanvas%2Fnf-variable-registry.js#L1628-L1636 [View Diff](https://github.com/2lambda123/NorthropGrumman-nifi/pull/1/files#diff-fac3438ca6ee10c1ef9432b37c1760c67a92346956a3d5668ce9bf530a6165b2R1628-R1636)

code-companion-ai[bot] commented 3 months ago

Processing PR updates...

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent update to the nf-variable-registry.js file introduces a new "Cancel" button configuration. This enhancement includes setting specific colors for the button and implementing a click handler to hide a modal, improving user experience and interface control.

Changes

File Path Change Summary
.../nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/... Added a "Cancel" button with color settings and a click handler to hide a modal in nf-variable-registry.js.

In the code a button gleams, A "Cancel" click to end our dreams. With colors bright and handlers tight, It hides the modal out of sight. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
quine-bot[bot] commented 3 months ago

👋 Figuring out if a PR is useful is hard, hopefully this will help.

  • @2lambda123 has been on GitHub since 2019 and in that time has had 2217 public PRs merged
  • They haven't contributed to this repo before
  • Here's a good example of their work: HeyGenClone
  • From looking at their profile, they seem to be good with Shell and Makefile.

Their most recently public accepted PR is: https://github.com/2lambda123/-mi-sdm439-android_device_xiaomi_mi439/pull/2

git-greetings[bot] commented 3 months ago

First PR by @2lambda123

PR Details of @2lambda123 in NorthropGrumman-nifi : OPEN CLOSED TOTAL
1 0 1
codeautopilot[bot] commented 3 months ago

undefined

codesyncapp[bot] commented 3 months ago

Check out the playback for this Pull Request here.