Moved the hide call on the new-rule-dialog to the end of the valid/su…

[2lambda123]

…ccess path

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

• [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

• [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

• [ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

• [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• [ ] Have you written or updated unit tests to verify your changes?
• [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
• [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Summary by CodeRabbit

• Bug Fixes
  • Improved dialog handling to ensure it closes only under specific conditions, enhancing user experience and preventing unintended closures.

[performance-testing-bot[bot]]

Unable to locate .performanceTestingBot config file

[cr-gpt[bot]]

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

[code-companion-ai[bot]]

Processing PR updates...

[git-greetings[bot]]

Thanks @2lambda123 for opening this PR!

For COLLABORATOR only :

• To add labels, comment on the issue /label add label1,label2,label3

• To remove labels, comment on the issue /label remove label1,label2,label3

[quine-bot[bot]]

👋 Figuring out if a PR is useful is hard, hopefully this will help.

• @2lambda123 has been on GitHub since 2019 and in that time has had 2218 public PRs merged
• Don't you recognize them? They've been here before 🎉
• Here's a good example of their work: HeyGenClone
• From looking at their profile, they seem to be good with Shell and Makefile.

Their most recently public accepted PR is: https://github.com/2lambda123/NorthropGrumman-nifi/pull/1

[sweep-ai[bot]]

Sweep: PR Review

nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/webapp/js/application.js

The change ensures that the 'new-rule-dialog' is only closed after the new rule has been successfully added and the rule filter has been re-applied.

Potential Issues

Sweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.

• The dialog will not close if the success callback is never reached, potentially leaving the dialog open indefinitely in case of an error.
https://github.com/2lambda123/NorthropGrumman-nifi/blob/67fa33f4dc5a3042dd5bdfa25fb956e3730dfd42/nifi-nar-bundles%2Fnifi-update-attribute-bundle%2Fnifi-update-attribute-ui%2Fsrc%2Fmain%2Fwebapp%2Fjs%2Fapplication.js#L400 [View Diff](https://github.com/2lambda123/NorthropGrumman-nifi/pull/2/files#diff-2275bf9b0497b12837dcf724852b62ac4b108f02b5aa12cf5d586cb1acdc01e8R400)

---

[git-greetings[bot]]

PR Details of @2lambda123 in NorthropGrumman-nifi :	OPEN	CLOSED	TOTAL
1	1	2

[coderabbitai[bot]]

Walkthrough

The recent update to the nifi-update-attribute-ui module's application.js file refines the logic for closing dialogs. The code responsible for this action has been moved inside a specific condition block to ensure dialogs are only closed when the appropriate conditions are met, enhancing the user interface's responsiveness and reliability.

Changes

File Path	Change Summary
nifi-nar-bundles/.../nifi-update-attribute-ui/src/main/webapp/js/application.js	Moved dialog-closing code into a specific condition block to ensure it executes only under certain conditions.

In lines of code, a change so slight,
Dialogs now close just right.
Conditions met, they disappear,
Enhancing user flow, it's clear.
🐇✨ In code we trust, improvements near,
A smoother path, we now revere.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[codeautopilot[bot]]

undefined

_Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect._ Current plan usage: 87.20% **Have feedback or need help?** [Discord](https://discord.gg/r72ykfvyx7) [Documentation](https://docs.codeautopilot.com/) [support@codeautopilot.com](mailto:support@codeautopilot.com)

[codesyncapp[bot]]

Check out the playback for this Pull Request here.