Feature/terraform deployment stacks

[2lambda123]

Description

Related Issue

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• [ ] I have read the Code of Conduct
• [ ] I have updated the documentation accordingly.
• [ ] All commits are GPG signed

Summary by Sourcery

Introduce new ECS task definition checks for logging, privileged access, and external image sources. Update Terraform configurations to replace CloudFormation stacks with direct resource definitions. Enhance logging and notification systems to include ECS-related issues. Add new documentation and test cases for the new ECS features.

New Features:

• Introduce new ECS task definition checks for logging, privileged access, and external image sources, enhancing the identification of potential security issues.
• Add new DynamoDB tables for tracking ECS-related issues, including logging, privileged access, and external image sources.
• Implement new Lambda functions for ECS task definition evaluations, including logging, privileged access, and external image source checks.

Enhancements:

• Refactor existing Terraform configurations to replace AWS CloudFormation stacks with direct resource definitions for better modularity and control.
• Enhance the logging and notification system to include new ECS-related issues, improving monitoring and alerting capabilities.

Deployment:

• Update Terraform deployment scripts to include new ECS-related resources and configurations, ensuring comprehensive deployment of new features.

Documentation:

• Add new documentation sections for ECS logging, privileged access, and external image source issues, providing detailed guidance on configuration and remediation.
• Update existing documentation to reflect changes in deployment and configuration processes related to the new ECS features.

Tests:

• Add new test cases for ECS logging, privileged access, and external image source checks, ensuring the reliability and accuracy of the new features.

Description by Korbit AI

What change is being made?

Integrate ECS detection capabilities into the deployment by adding new ECS-related Lambda functions, DynamoDB tables, IAM roles, and configuration settings to address ECS logging, privileged access, and external image sources.

Why are these changes being made?

These changes are introduced to extend the security compliance capabilities of the system to ECS services, enabling the detection and reporting of unauthorized privileged access, logging issues, and use of unauthorized external image sources in ECS task definitions. This is part of an ongoing effort to enhance security monitoring across various AWS services, and it fills a gap in identifying and resolving ECS-related security issues.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced new Lambda functions for detecting ECS logging, privileged access, and external image source issues.
  • Added new DynamoDB tables for enhanced data management related to ECS functionalities.
  • Expanded configuration options for ECS-related monitoring and logging.
  • Updated documentation with new playbooks and configuration parameters for ECS.

• Bug Fixes

  • Improved error handling and logging for ECS-related checks.

• Documentation

  • Enhanced deployment instructions and added new sections for ECS configurations in the documentation.

• Tests

  • Added unit tests for new ECS-related functionalities to ensure reliability and performance.

[performance-testing-bot[bot]]

Unable to locate .performanceTestingBot config file

[cr-gpt[bot]]

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

[code-companion-ai[bot]]

Processing PR updates...

[git-greetings[bot]]

Thanks @2lambda123 for opening this PR!

For COLLABORATOR only :

• To add labels, comment on the issue /label add label1,label2,label3

• To remove labels, comment on the issue /label remove label1,label2,label3

[quine-bot[bot]]

👋 Figuring out if a PR is useful is hard, hopefully this will help.

• @2lambda123 has been on GitHub since 2019 and in that time has had 2898 public PRs merged
• They haven't contributed to this repo before
• Here's a good example of their work: black-forest-labs-flux
• From looking at their profile, they seem to be good with Python and Shell.

Their most recently public accepted PR is: https://github.com/2lambda123/perlin-network-wavelet/pull/10

[korbit-ai[bot]]

Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

[git-greetings[bot]]

First PR by @2lambda123

PR Details of @2lambda123 in dowjones-hammer :	OPEN	CLOSED	TOTAL
1	0	1

[coderabbitai[bot]]

[!WARNING]

Rate limit exceeded

@labels-and-badges[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 674028a067cad91ce1a84577d30afe7b895f2a6a and 0b7e5afcc3a04c1714f7c71ca8735e357622d425.

Walkthrough

The changes in this pull request encompass the addition of new functionalities related to ECS (Elastic Container Service) within the Dow Jones Hammer application. Key updates include modifications to scripts for building packages, new DynamoDB tables, IAM role policies, and CloudFormation templates. Additional Lambda functions have been introduced to handle ECS logging, privileged access, and external image source issues. Documentation has been updated to reflect these changes, enhancing the overall capabilities of the system in monitoring and reporting ECS-related issues.

Changes

File	Change Summary
deployment/build_packages.sh	Updated LAMBDAS variable to include new Lambda functions: ecs-privileged-access-issues-identification, ecs-logging-issues-identification, ecs-external-image-source-issues-identification.
deployment/cf-templates/ddb.json	Added three new DynamoDB tables: DynamoDBECSPrivilegedAccess, DynamoDBECSLogging, DynamoDBECSExternalImageSource.
deployment/cf-templates/identification-crossaccount-role.json	Added new IAM policy ECSIssues allowing ecs:Describe* and ecs:List* actions.
deployment/cf-templates/identification-role.json	Added new IAM policy ECSIssues allowing ecs:Describe* and ecs:List* actions.
deployment/cf-templates/identification.json	Introduced new parameters and resources for ECS functionalities, including mappings for SNS display names and topics.
deployment/cf-templates/reporting-remediation-crossaccount-role.json	Added new IAM policy ECSIssues allowing ecs:Describe* and ecs:List* actions.
deployment/cf-templates/reporting-remediation-role.json	Added new IAM policy ECSIssues allowing ecs:Describe* and ecs:List* actions.
deployment/configs/config.json	Added new configuration sections for ECS: ecs_privileged_access, ecs_logging, ecs_external_image_source.
deployment/configs/whitelist.json	Added new entries for ECS-related issues and updated existing entries for s3_encryption and rds_encryption.
deployment/terraform/modules/ddb/ddb.tf	Removed previous CloudFormation stack and added multiple aws_dynamodb_table resources for various configurations.
deployment/terraform/modules/identification-nested/identification_nested_template.tf	Introduced new Lambda functions, CloudWatch log groups, and event rules for ECS monitoring.
deployment/terraform/modules/identification-nested/input.tf	Added new variable declarations for Lambda functions and event rules.
deployment/terraform/modules/identification/identification.tf	Added new Lambda functions and event rules for identification tasks.
deployment/terraform/modules/identification/output.tf	Updated output declaration for lambdaLogsForwarderArn.
deployment/terraform/modules/identification/sources.tf	Added new S3 bucket object resources for ECS issue identification.
deployment/terraform/modules/identification/variables.tf	Introduced new variables for SNS topics and Lambda functions related to ECS.
deployment/terraform/tf_templates/ddb/ddb_template.tf	Added multiple DynamoDB table resources for various configurations.
deployment/terraform/tf_templates/ddb/input.tf	Added variables for resource prefix and tags.
deployment/terraform/tf_templates/identification/identification_template.tf	Added Lambda functions and CloudWatch configurations.
deployment/terraform/tf_templates/identification/input.tf	Added variables for resource prefix and tags.
docs/_data/sidebars/mydoc_sidebar.yml	Added new entries for ECS-related playbooks in documentation sidebar.
docs/pages/deployment_cloudformation.md	Updated deployment instructions with new parameters for ECS.
docs/pages/editconfig.md	Added new sections for ECS logging, privileged access, and external image source issues.
docs/pages/features.md	Updated features documentation to include new ECS-related security features.
docs/pages/playbook19_ecs_privileged_access.md	New playbook for ECS privileged access issue detection.
docs/pages/playbook20_ecs_external_image_source.md	New playbook for detecting ECS external image sources.
docs/pages/remediation_backup_rollback.md	Added new issue type for ECS privileged access in remediation table.
hammer/identification/lambdas/ecs-external-image-source-issues-identification/describe_ecs_external_image_source_issues.py	New Lambda function for evaluating ECS external image sources.
hammer/identification/lambdas/ecs-external-image-source-issues-identification/initiate_to_desc_ecs_external_image_source_issues.py	New Lambda function to initiate checks for ECS external image sources.
hammer/identification/lambdas/ecs-logging-issues-identification/describe_ecs_logging_issues.py	New Lambda function for evaluating ECS logging issues.
hammer/identification/lambdas/ecs-logging-issues-identification/initiate_to_desc_ecs_logging_issues.py	New Lambda function to initiate checks for ECS logging.
hammer/identification/lambdas/ecs-privileged-access-issues-identification/describe_ecs_privileged_access_issues.py	New Lambda function for evaluating ECS privileged access issues.
hammer/identification/lambdas/ecs-privileged-access-issues-identification/initiate_to_desc_ecs_privileged_access_issues.py	New Lambda function to initiate checks for ECS privileged access.
hammer/library/aws/ecs.py	New functionality for managing ECS clusters and task definitions.
hammer/library/config.py	Added new ECS-related configurations in the Config class.
hammer/library/ddb_issues.py	Added new classes for ECS logging, privileged access, and external image source issues.
hammer/reporting-remediation/analytics/security_issues_csv_report.py	Updated reporting functionality to include new ECS issue types.
hammer/reporting-remediation/cronjobs/automation_scheduler.py	Added new modules for ECS issues in the automation scheduler.
hammer/reporting-remediation/reporting/create_ecs_external_image_source_issue_tickets.py	New class for creating Jira tickets for ECS external image source issues.
hammer/reporting-remediation/reporting/create_ecs_logging_issue_tickets.py	New class for creating Jira tickets for ECS logging issues.
hammer/reporting-remediation/reporting/create_ecs_privileged_access_issue_tickets.py	New class for creating Jira tickets for ECS privileged access issues.
tests/mock_ecs.py	New mock functionalities for ECS testing.
tests/test_ecs_external_image_source.py	New unit tests for ECS external image source issues.
tests/test_ecs_logging.py	New unit tests for ECS logging issues.
tests/test_ecs_privileged_access.py	New unit tests for ECS privileged access issues.
tox.ini	Updated pytest paths to include new ECS-related tests.

Poem

In the meadow, hops a rabbit bright,
With changes made, oh what a sight!
ECS logging, access, and more,
New paths to explore, new tales to score.
With Lambda and Dynamo, we leap with glee,
In the world of code, come dance with me! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This pull request replaces CloudFormation templates with Terraform configurations for AWS infrastructure deployment, focusing on ECS-related security checks including privileged access, logging, and image source validation. The changes include new Lambda functions, DynamoDB tables, and associated monitoring resources.

ER diagram for new DynamoDB tables

erDiagram
    credentials {
        STRING service PK
    }
    cloudtrails {
        STRING account_id PK
        STRING issue_id PK
    }
    security-groups-unrestricted {
        STRING account_id PK
        STRING issue_id PK
    }
    s3-public-bucket-acl {
        STRING account_id PK
        STRING issue_id PK
    }
    s3-public-bucket-policy {
        STRING account_id PK
        STRING issue_id PK
    }
    iam-user-keys-rotation {
        STRING account_id PK
        STRING issue_id PK
    }
    iam-user-keys-inactive {
        STRING account_id PK
        STRING issue_id PK
    }
    ebs-volumes-unencrypted {
        STRING account_id PK
        STRING issue_id PK
    }
    ebs-snapshots-public {
        STRING account_id PK
        STRING issue_id PK
    }
    rds-public-snapshots {
        STRING account_id PK
        STRING issue_id PK
    }
    sqs-public-access {
        STRING account_id PK
        STRING issue_id PK
    }
    s3-unencrypted {
        STRING account_id PK
        STRING issue_id PK
    }
    rds-unencrypted {
        STRING account_id PK
        STRING issue_id PK
    }
    ec2-public-ami {
        STRING account_id PK
        STRING issue_id PK
    }
    api-requests {
        STRING request_id PK
    }
    ecs-privileged-access {
        STRING account_id PK
        STRING issue_id PK
    }
    ecs-logging {
        STRING account_id PK
        STRING issue_id PK
    }
    ecs-external-image-source {
        STRING account_id PK
        STRING issue_id PK
    }

Class diagram for ECS issue classes

classDiagram
    class ECSLoggingIssue {
        +ECSLoggingIssue(args)
    }
    class ECSPrivilegedAccessIssue {
        +ECSPrivilegedAccessIssue(args)
    }
    class ECSExternalImageSourceIssue {
        +ECSExternalImageSourceIssue(args)
    }
    class Issue
    Issue <|-- ECSLoggingIssue
    Issue <|-- ECSPrivilegedAccessIssue
    Issue <|-- ECSExternalImageSourceIssue
    note for ECSLoggingIssue "Handles ECS logging issues"
    note for ECSPrivilegedAccessIssue "Handles ECS privileged access issues"
    note for ECSExternalImageSourceIssue "Handles ECS external image source issues"

File-Level Changes

Change	Details	Files
Migrated infrastructure deployment from CloudFormation to Terraform	Replaced CloudFormation stack with native Terraform resources for identification module Created Terraform templates for DynamoDB tables and identification resources Added input variable definitions for Terraform modules Implemented resource dependencies and references using Terraform syntax	deployment/terraform/modules/identification/identification.tf deployment/terraform/modules/ddb/ddb.tf deployment/terraform/tf_templates/ddb/ddb_template.tf deployment/terraform/tf_templates/identification/identification_template.tf
Added ECS security check functionality	Implemented ECS privileged access checking Added ECS logging validation Created ECS external image source detection Added DynamoDB tables for storing ECS security findings Created Lambda functions for ECS security checks	hammer/library/aws/ecs.py hammer/identification/lambdas/ecs-privileged-access-issues-identification/ hammer/identification/lambdas/ecs-logging-issues-identification/ hammer/identification/lambdas/ecs-external-image-source-issues-identification/
Enhanced reporting and documentation	Added reporting modules for ECS security issues Created documentation for ECS security checks Updated configuration examples and playbooks Added test cases for ECS security validations	hammer/reporting-remediation/reporting/create_ecs_privileged_access_issue_tickets.py hammer/reporting-remediation/reporting/create_ecs_logging_issue_tickets.py hammer/reporting-remediation/reporting/create_ecs_external_image_source_issue_tickets.py docs/pages/playbook19_ecs_privileged_access.md docs/pages/playbook20_ecs_external_image_source.md

---

Tips and commands

#### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).

[codeautopilot[bot]]

PR summary

This pull request introduces new features to the existing infrastructure by adding support for identifying and managing ECS-related issues using Terraform deployment stacks. Specifically, it adds functionality to detect ECS logging issues, ECS privileged access issues, and ECS external image source issues. The changes include updates to CloudFormation templates, Terraform modules, and configuration files to support these new features. Additionally, it includes new Lambda functions for issue identification and reporting, as well as updates to the documentation to reflect these changes.

Suggestion

1. Ensure that all new Lambda functions are thoroughly tested and validated in a staging environment before deploying to production.
2. Consider adding more detailed comments in the code to improve maintainability and ease of understanding for future developers.
3. Review the documentation for completeness and clarity, ensuring that all new features are well-documented for end-users.
4. Evaluate the potential impact on existing infrastructure and ensure backward compatibility with current deployments.

_Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect._ Current plan usage: 17.90% **Have feedback or need help?** [Discord](https://discord.gg/r72ykfvyx7) [Documentation](https://docs.codeautopilot.com/) [support@codeautopilot.com](mailto:support@codeautopilot.com)

[sweep-ai[bot]]

Hey @2lambda123, here is an example of how you can ask me to improve this pull request:

@sweep Add unit tests for the ECSChecker class in `library/aws/ecs.py` to test the `get_ecs_instance_security_groups` method, which currently has no test coverage.

:book: For more information on how to use Sweep, please read our documentation.

[sweep-ai[bot]]

Hey @2lambda123, here is an example of how you can ask me to improve this pull request:

@sweep Add unit tests for the ECSChecker class in `library/aws/ecs.py` to test the `get_ecs_instance_security_groups` method, which currently has no test coverage.

:book: For more information on how to use Sweep, please read our documentation.

[pep8speaks]

Hello @2lambda123! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file hammer/identification/lambdas/ecs-external-image-source-issues-identification/describe_ecs_external_image_source_issues.py:

Line 14:80: E501 line too long (99 > 79 characters) Line 23:80: E501 line too long (86 > 79 characters) Line 33:80: E501 line too long (108 > 79 characters) Line 42:80: E501 line too long (109 > 79 characters) Line 45:80: E501 line too long (113 > 79 characters) Line 48:80: E501 line too long (110 > 79 characters) Line 56:80: E501 line too long (89 > 79 characters) Line 59:80: E501 line too long (105 > 79 characters) Line 61:80: E501 line too long (103 > 79 characters) Line 65:80: E501 line too long (90 > 79 characters) Line 71:80: E501 line too long (80 > 79 characters) Line 72:80: E501 line too long (92 > 79 characters) Line 76:80: E501 line too long (83 > 79 characters) Line 78:80: E501 line too long (90 > 79 characters) Line 81:80: E501 line too long (102 > 79 characters) Line 89:80: E501 line too long (103 > 79 characters) Line 91:80: E501 line too long (86 > 79 characters) Line 93:1: W391 blank line at end of file

• In the file hammer/identification/lambdas/ecs-external-image-source-issues-identification/initiate_to_desc_ecs_external_image_source_issues.py:

Line 10:80: E501 line too long (103 > 79 characters) Line 19:80: E501 line too long (81 > 79 characters) Line 22:80: E501 line too long (105 > 79 characters) Line 23:80: E501 line too long (90 > 79 characters) Line 28:23: E124 closing bracket does not match visual indentation Line 29:80: E501 line too long (105 > 79 characters) Line 33:80: E501 line too long (107 > 79 characters) Line 36:80: E501 line too long (80 > 79 characters)

• In the file hammer/identification/lambdas/ecs-logging-issues-identification/describe_ecs_logging_issues.py:

Line 23:80: E501 line too long (86 > 79 characters) Line 33:80: E501 line too long (94 > 79 characters) Line 42:80: E501 line too long (95 > 79 characters) Line 45:80: E501 line too long (101 > 79 characters) Line 48:80: E501 line too long (110 > 79 characters) Line 58:80: E501 line too long (81 > 79 characters) Line 59:80: E501 line too long (123 > 79 characters) Line 62:80: E501 line too long (89 > 79 characters) Line 66:80: E501 line too long (90 > 79 characters) Line 72:80: E501 line too long (80 > 79 characters) Line 73:80: E501 line too long (92 > 79 characters) Line 76:80: E501 line too long (83 > 79 characters) Line 78:80: E501 line too long (90 > 79 characters) Line 81:80: E501 line too long (102 > 79 characters) Line 91:80: E501 line too long (86 > 79 characters) Line 93:1: W391 blank line at end of file

• In the file hammer/identification/lambdas/ecs-logging-issues-identification/initiate_to_desc_ecs_logging_issues.py:

Line 22:80: E501 line too long (90 > 79 characters) Line 28:23: E124 closing bracket does not match visual indentation Line 29:80: E501 line too long (90 > 79 characters) Line 33:80: E501 line too long (92 > 79 characters)

• In the file hammer/identification/lambdas/ecs-privileged-access-issues-identification/describe_ecs_privileged_access_issues.py:

Line 23:80: E501 line too long (86 > 79 characters) Line 33:80: E501 line too long (104 > 79 characters) Line 42:80: E501 line too long (105 > 79 characters) Line 45:80: E501 line too long (110 > 79 characters) Line 48:80: E501 line too long (110 > 79 characters) Line 49:80: E501 line too long (92 > 79 characters) Line 56:80: E501 line too long (86 > 79 characters) Line 59:80: E501 line too long (111 > 79 characters) Line 61:80: E501 line too long (99 > 79 characters) Line 65:80: E501 line too long (90 > 79 characters) Line 71:80: E501 line too long (88 > 79 characters) Line 72:80: E501 line too long (92 > 79 characters) Line 75:80: E501 line too long (83 > 79 characters) Line 77:80: E501 line too long (90 > 79 characters) Line 80:80: E501 line too long (110 > 79 characters) Line 90:80: E501 line too long (94 > 79 characters) Line 92:1: W391 blank line at end of file

• In the file hammer/identification/lambdas/ecs-privileged-access-issues-identification/initiate_to_desc_ecs_privileged_access_issues.py:

Line 10:80: E501 line too long (80 > 79 characters) Line 22:80: E501 line too long (92 > 79 characters) Line 23:80: E501 line too long (86 > 79 characters) Line 28:23: E124 closing bracket does not match visual indentation Line 29:80: E501 line too long (92 > 79 characters) Line 33:80: E501 line too long (94 > 79 characters)

• In the file hammer/library/aws/ecs.py:

Line 20:80: E501 line too long (80 > 79 characters) Line 39:80: E501 line too long (82 > 79 characters) Line 49:80: E501 line too long (115 > 79 characters) Line 66:80: E501 line too long (104 > 79 characters) Line 67:80: E501 line too long (90 > 79 characters) Line 75:80: E501 line too long (89 > 79 characters) Line 76:80: E501 line too long (91 > 79 characters) Line 78:80: E501 line too long (93 > 79 characters) Line 79:39: W291 trailing whitespace Line 80:80: E501 line too long (100 > 79 characters) Line 88:80: E501 line too long (80 > 79 characters) Line 97:80: E501 line too long (108 > 79 characters) Line 118:80: E501 line too long (99 > 79 characters) Line 119:80: E501 line too long (81 > 79 characters) Line 121:80: E501 line too long (90 > 79 characters) Line 125:80: E501 line too long (87 > 79 characters) Line 130:80: E501 line too long (97 > 79 characters) Line 138:80: E501 line too long (90 > 79 characters) Line 143:80: E501 line too long (92 > 79 characters) Line 145:80: E501 line too long (84 > 79 characters) Line 146:80: E501 line too long (87 > 79 characters) Line 148:80: E501 line too long (83 > 79 characters) Line 150:80: E501 line too long (81 > 79 characters) Line 155:80: E501 line too long (95 > 79 characters) Line 156:80: E501 line too long (84 > 79 characters) Line 158:80: E501 line too long (81 > 79 characters) Line 177:80: E501 line too long (90 > 79 characters) Line 178:80: E501 line too long (95 > 79 characters) Line 179:80: E501 line too long (93 > 79 characters) Line 181:80: E501 line too long (96 > 79 characters) Line 182:80: E501 line too long (135 > 79 characters) Line 183:80: E501 line too long (97 > 79 characters) Line 184:80: E501 line too long (123 > 79 characters) Line 185:80: E501 line too long (99 > 79 characters) Line 186:80: E501 line too long (117 > 79 characters) Line 190:80: E501 line too long (98 > 79 characters) Line 194:80: E501 line too long (99 > 79 characters) Line 198:20: W292 no newline at end of file

• In the file hammer/library/config.py:

Line 72:80: E501 line too long (88 > 79 characters) Line 75:80: E501 line too long (96 > 79 characters)

• In the file hammer/library/ddb_issues.py:

Line 240:1: E302 expected 2 blank lines, found 1 Line 241:4: E111 indentation is not a multiple of four Line 242:9: E117 over-indented Line 246:4: E111 indentation is not a multiple of four Line 247:9: E117 over-indented

• In the file hammer/reporting-remediation/analytics/security_issues_csv_report.py:

Line 11:80: E501 line too long (117 > 79 characters) Line 12:80: E501 line too long (117 > 79 characters) Line 75:80: E501 line too long (121 > 79 characters) Line 76:80: E501 line too long (92 > 79 characters) Line 77:80: E501 line too long (96 > 79 characters)

• In the file hammer/reporting-remediation/cronjobs/automation_scheduler.py:

Line 60:80: E501 line too long (123 > 79 characters) Line 61:80: E501 line too long (93 > 79 characters) Line 62:80: E501 line too long (128 > 79 characters)

• In the file hammer/reporting-remediation/reporting/create_ecs_external_image_source_issue_tickets.py:

Line 32:80: E501 line too long (95 > 79 characters) Line 34:80: E501 line too long (118 > 79 characters) Line 39:80: E501 line too long (85 > 79 characters) Line 46:80: E501 line too long (87 > 79 characters) Line 47:80: E501 line too long (127 > 79 characters) Line 49:80: E501 line too long (124 > 79 characters) Line 50:80: E501 line too long (100 > 79 characters) Line 63:80: E501 line too long (130 > 79 characters) Line 69:80: E501 line too long (85 > 79 characters) Line 71:80: E501 line too long (132 > 79 characters) Line 73:80: E501 line too long (103 > 79 characters) Line 74:80: E501 line too long (96 > 79 characters) Line 75:80: E501 line too long (130 > 79 characters) Line 82:80: E501 line too long (81 > 79 characters) Line 85:80: E501 line too long (108 > 79 characters) Line 91:80: E501 line too long (90 > 79 characters) Line 92:80: E501 line too long (114 > 79 characters) Line 102:80: E501 line too long (86 > 79 characters) Line 110:80: E501 line too long (102 > 79 characters) Line 112:80: E501 line too long (85 > 79 characters) Line 113:80: E501 line too long (100 > 79 characters) Line 114:80: E501 line too long (104 > 79 characters) Line 116:80: E501 line too long (112 > 79 characters) Line 118:80: E501 line too long (107 > 79 characters) Line 119:80: E501 line too long (96 > 79 characters) Line 125:80: E501 line too long (93 > 79 characters) Line 137:80: E501 line too long (91 > 79 characters) Line 145:80: E501 line too long (126 > 79 characters) Line 156:80: E501 line too long (82 > 79 characters) Line 165:80: E501 line too long (90 > 79 characters)

• In the file hammer/reporting-remediation/reporting/create_ecs_logging_issue_tickets.py:

Line 32:80: E501 line too long (81 > 79 characters) Line 34:80: E501 line too long (106 > 79 characters) Line 37:80: E501 line too long (103 > 79 characters) Line 46:80: E501 line too long (87 > 79 characters) Line 47:80: E501 line too long (121 > 79 characters) Line 49:80: E501 line too long (118 > 79 characters) Line 50:80: E501 line too long (100 > 79 characters) Line 63:80: E501 line too long (130 > 79 characters) Line 69:80: E501 line too long (85 > 79 characters) Line 71:80: E501 line too long (132 > 79 characters) Line 73:80: E501 line too long (89 > 79 characters) Line 74:80: E501 line too long (96 > 79 characters) Line 75:80: E501 line too long (130 > 79 characters) Line 82:80: E501 line too long (81 > 79 characters) Line 85:80: E501 line too long (90 > 79 characters) Line 91:80: E501 line too long (95 > 79 characters) Line 92:80: E501 line too long (114 > 79 characters) Line 101:80: E501 line too long (119 > 79 characters) Line 110:80: E501 line too long (120 > 79 characters) Line 111:80: E501 line too long (100 > 79 characters) Line 113:80: E501 line too long (106 > 79 characters) Line 114:80: E501 line too long (120 > 79 characters) Line 116:80: E501 line too long (82 > 79 characters) Line 117:80: E501 line too long (114 > 79 characters) Line 124:80: E501 line too long (93 > 79 characters) Line 136:80: E501 line too long (91 > 79 characters) Line 144:80: E501 line too long (126 > 79 characters) Line 155:80: E501 line too long (82 > 79 characters) Line 164:80: E501 line too long (90 > 79 characters)

• In the file hammer/reporting-remediation/reporting/create_ecs_privileged_access_issue_tickets.py:

Line 32:80: E501 line too long (91 > 79 characters) Line 34:80: E501 line too long (115 > 79 characters) Line 37:80: E501 line too long (91 > 79 characters) Line 46:80: E501 line too long (87 > 79 characters) Line 47:80: E501 line too long (101 > 79 characters) Line 50:80: E501 line too long (98 > 79 characters) Line 52:80: E501 line too long (100 > 79 characters) Line 65:80: E501 line too long (130 > 79 characters) Line 71:80: E501 line too long (85 > 79 characters) Line 73:80: E501 line too long (132 > 79 characters) Line 75:80: E501 line too long (108 > 79 characters) Line 76:80: E501 line too long (96 > 79 characters) Line 77:80: E501 line too long (130 > 79 characters) Line 84:80: E501 line too long (81 > 79 characters) Line 87:80: E501 line too long (104 > 79 characters) Line 93:80: E501 line too long (101 > 79 characters) Line 94:80: E501 line too long (114 > 79 characters) Line 103:80: E501 line too long (109 > 79 characters) Line 112:80: E501 line too long (113 > 79 characters) Line 114:80: E501 line too long (100 > 79 characters) Line 116:80: E501 line too long (106 > 79 characters) Line 117:80: E501 line too long (120 > 79 characters) Line 119:80: E501 line too long (82 > 79 characters) Line 120:80: E501 line too long (106 > 79 characters) Line 127:80: E501 line too long (93 > 79 characters) Line 139:80: E501 line too long (91 > 79 characters) Line 147:80: E501 line too long (126 > 79 characters) Line 158:80: E501 line too long (82 > 79 characters) Line 167:80: E501 line too long (90 > 79 characters)

• In the file tests/mock_ecs.py:

Line 19:80: E501 line too long (98 > 79 characters) Line 45:1: W391 blank line at end of file

• In the file tests/test_ecs_external_image_source.py:

Line 4:5: E271 multiple spaces after keyword Line 43:80: E501 line too long (107 > 79 characters) Line 51:80: E501 line too long (84 > 79 characters) Line 57:80: E501 line too long (89 > 79 characters) Line 61:80: E501 line too long (90 > 79 characters) Line 70:80: E501 line too long (109 > 79 characters) Line 80:80: E501 line too long (94 > 79 characters) Line 84:68: W292 no newline at end of file

• In the file tests/test_ecs_logging.py:

Line 4:5: E271 multiple spaces after keyword Line 65:80: E501 line too long (107 > 79 characters) Line 73:80: E501 line too long (84 > 79 characters) Line 79:80: E501 line too long (89 > 79 characters) Line 83:80: E501 line too long (90 > 79 characters) Line 92:80: E501 line too long (109 > 79 characters) Line 102:80: E501 line too long (94 > 79 characters)

• In the file tests/test_ecs_privileged_access.py:

Line 4:5: E271 multiple spaces after keyword Line 50:80: E501 line too long (107 > 79 characters) Line 58:80: E501 line too long (84 > 79 characters) Line 64:80: E501 line too long (89 > 79 characters) Line 68:80: E501 line too long (90 > 79 characters) Line 77:80: E501 line too long (109 > 79 characters) Line 87:80: E501 line too long (94 > 79 characters)

[penify-dev[bot]]

Failed to generate code suggestions for PR

[secure-code-warrior-for-github[bot]]

Micro-Learning Topic: External entity injection (Detected by phrase)

Matched on "xXE"

What is this? (2min video)

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server-side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Try a challenge in Secure Code Warrior

Helpful references

• OWASP XML External Entity (XXE) Processing - OWASP community page with comprehensive information about XML external entity attacks, and links to various OWASP resources to help detect or prevent it.
• MSDN Security Briefs - XML Denial of Service Attacks and Defenses - An MSDN Magazine article that goes into detail on XML entity attacks and how to defend against them.
• OWASP XML External Entity Prevention Cheat Sheet - This article is focused on providing clear, simple, actionable guidance for preventing XML external entity flaws in your applications.

[secure-code-warrior-for-github[bot]]

Micro-Learning Topic: Cross-site scripting (Detected by phrase)

Matched on "XsS"

What is this? (2min video)

Cross-site scripting vulnerabilities occur when unescaped input is rendered into a page displayed to the user. When HTML or script is included in the input, it will be processed by a user's browser as HTML or script and can alter the appearance of the page or execute malicious scripts in their user context.

Try a challenge in Secure Code Warrior

Helpful references

• Prevent Cross-Site Scripting (XSS) in ASP.NET Core - A detailed Microsoft article on how to prevent cross-site scripting in ASP.NET Core.
• OWASP Cross Site Scripting (XSS) Software Attack - OWASP community page with comprehensive information about cross site scripting, and links to various OWASP resources to help detect or prevent it.
• OWASP Cross Site Scripting Prevention Cheat Sheet - This article provides a simple positive model for preventing XSS using output encoding properly.

[performance-testing-bot[bot]]

There was an issue running the performance test