Closed 2lambda123 closed 3 months ago
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information
Processing PR updates...
Thanks @2lambda123 for opening this PR!
For COLLABORATOR only :
To add labels, comment on the issue
/label add label1,label2,label3
To remove labels, comment on the issue
/label remove label1,label2,label3
Unable to locate .performanceTestingBot config file
Your organization has reached the subscribed usage limit. You can upgrade your account by purchasing a subscription at Stripe payment link
PR Details of @2lambda123 in ethereum-js-ethereum-cryptography : | OPEN | CLOSED | TOTAL |
---|---|---|---|
2 | 0 | 2 |
This pull request switches the testing framework to micro-should. The changes involve importing the 'describe' and 'it' functions from micro-should in multiple test files, and removing or commenting out 'this.timeout()' calls. This change affects several test vector files across different cryptographic functions.
Files | Changes |
---|---|
test/test-vectors/scrypt.ts test/test-vectors/aes.ts test/test-vectors/blake2b.ts test/test-vectors/hdkey.ts test/test-vectors/keccak.ts test/test-vectors/pbkdf2.ts test/test-vectors/ripemd160.ts test/test-vectors/sha256.ts test/test-vectors/sha512.ts |
Import 'describe' and 'it' functions from micro-should |
test/test-vectors/scrypt.ts |
Remove or comment out 'this.timeout()' calls |
👋 Figuring out if a PR is useful is hard, hopefully this will help.
- @2lambda123 has been on GitHub since 2019 and in that time has had 2579 public PRs merged
- They haven't contributed to this repo before
- Here's a good example of their work: black-forest-labs-flux
- From looking at their profile, they seem to be good with Java and Shell.
Their most recently public accepted PR is: https://github.com/2lambda123/yotadevices-Viscera/pull/1
Description has been updated!
[!WARNING]
Rate limit exceeded
@labels-and-badges[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 30 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 9faadf5f1dda4aa95cc675d927281862ac7bf7e7 and 136f5f16bdc8a68e2c7dca46ec55c45fc75dedf6.
The update introduces the micro-should
testing library to enhance the project's testing framework. This change allows for a more structured, behavior-driven approach to test writing across various cryptographic modules. The addition promotes better readability and maintainability of the test code, while a new aggregate test index file organizes the testing environment.
Files | Change Summary |
---|---|
package.json |
Added "micro-should": "^0.3.0" to dependencies for enhanced testing capabilities. |
test/test-vectors/*.ts |
Imported describe and it from micro-should in multiple test files, enabling a structured testing approach for various cryptographic functionalities. |
test/test-vectors/index.ts |
Introduced a new module to aggregate tests from various cryptographic utilities, setting up the testing environment with micro-should . |
sequenceDiagram
participant T as Test Files
participant M as micro-should Library
participant I as Index File
T->>M: Import describe, it
T->>I: Run tests
I->>M: Execute test cases
M-->>T: Return test results
🐰 In the garden of code, new blooms arise,
Withmicro-should
sprouting, watch tests mesmerize.
Each case a delight, structured with care,
A dance of assertions, in the crisp morning air.
So hop with joy, for clarity's here,
In the realm of testing, let’s all cheer! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
In this pull request, several modifications and additions have been made to the test vectors across various test files in the project. Additionally, a new test-vectors/index.ts file has been added to aggregate and run tests for all modules. Here's a summary of the changes:
micro-should
as a new dependency.describe
andit
imports frommicro-should
to the test files.index.ts
file to aggregate and run tests from all modules.List of changes:
import { describe, it } from "micro-should";
to the following test files:aes.ts
,bip39.ts
,blake2b.ts
,hdkey.ts
,keccak.ts
,pbkdf2.ts
,random.ts
,ripemd160.ts
,scrypt.ts
,secp256k1-compat.ts
,secp256k1.ts
,sha256.ts
,sha512.ts
.test/test-vectors/index.ts
file to run tests for all modules.These changes aim to enhance the test structure and organization in the project by using the
micro-should
testing library and aggregating tests into a single file.Summary by Sourcery
Switch to using 'micro-should' for test descriptions and assertions in various test files, removing the use of timeout settings in tests.
Enhancements:
Summary by CodeRabbit
New Features
micro-should
library.Bug Fixes
Chores
micro-should
for better testing capabilities.