Feature/state machine phase 1

[2lambda123]

Description

Related Issue

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• [ ] I have read the Code of Conduct
• [ ] I have updated the documentation accordingly.
• [ ] All commits are GPG signed

Description by Korbit AI

Summary by Sourcery

Introduce state machine support in the FPP language, including definitions, instances, and behavior elements. Update the language specification and code generation to accommodate these changes, and add corresponding tests.

New Features:

• Introduce state machine definitions and instances in the FPP language, allowing components to define and use state machines.
• Add support for state machine behavior elements, including actions, guards, signals, and transitions, to define the behavior of state machines.

Enhancements:

• Update the FPP language specification to include state machine definitions and behavior elements, providing detailed syntax and semantics.
• Refactor the FPP writer and AST writer to handle state machine definitions and instances, ensuring proper code generation.
• Enhance the component C++ writer to support state machine instances, including initialization and dispatch logic.

Documentation:

• Update the FPP language specification document to include new sections on state machine definitions and behavior elements, providing examples and detailed explanations.

Tests:

• Add new test cases for parsing and handling state machine definitions and instances in the FPP language, ensuring correct syntax and semantics.

[performance-testing-bot[bot]]

Unable to locate .performanceTestingBot config file

[cr-gpt[bot]]

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

[code-companion-ai[bot]]

Processing PR updates...

[git-greetings[bot]]

Thanks @2lambda123 for opening this PR!

For COLLABORATOR only :

• To add labels, comment on the issue /label add label1,label2,label3

• To remove labels, comment on the issue /label remove label1,label2,label3

[korbit-ai[bot]]

My review is in progress :book: - I will have feedback for you in a few minutes!

[quine-bot[bot]]

👋 Figuring out if a PR is useful is hard, hopefully this will help.

• @2lambda123 has been on GitHub since 2019 and in that time has had 2664 public PRs merged
• Don't you recognize them? They've been here before 🎉
• Here's a good example of their work: black-forest-labs-flux
• From looking at their profile, they seem to be good with Python and Shell.

Their most recently public accepted PR is: https://github.com/2lambda123/nasa-fpp/pull/3

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This pull request implements the first phase of state machine support in FPP (F Prime Prime). It adds syntax and basic semantic analysis for state machine definitions and instances, but does not yet implement full state machine behavior or code generation. The changes include updates to the parser, AST, semantic analysis, and C++ code generation to support the new state machine constructs.

File-Level Changes

Change	Details	Files
Added syntax and AST nodes for state machine definitions and instances	Added 'state machine' and related keywords to the lexer Updated the parser to recognize state machine definitions and instances Added new AST nodes for DefStateMachine and SpecStateMachineInstance Updated ComponentMember and ModuleMember to include state machine nodes	compiler/lib/src/main/scala/syntax/Parser.scala compiler/lib/src/main/scala/ast/Ast.scala compiler/lib/src/main/scala/syntax/Lexer.scala
Implemented basic semantic analysis for state machines	Added state machine instances to the Component class Updated semantic checks to handle state machine constructs Added type checking for state machine instance priorities	compiler/lib/src/main/scala/analysis/Semantics/Component.scala compiler/lib/src/main/scala/analysis/CheckSemantics/CheckExprTypes.scala
Updated C++ code generation to include state machine-related constructs	Added state machine instance variables and initialization in component classes Included state machine-related headers in generated C++ code Added placeholders for state machine dispatch and overflow hooks	compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriter.scala compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriterUtils.scala compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentImplWriter.scala
Updated documentation and test cases	Updated FPP language specification to include state machine constructs Added test cases for state machine syntax and basic semantics Updated existing test cases to include state machine examples	docs/fpp-spec.html compiler/tools/fpp-syntax/test/syntax.fpp compiler/tools/fpp-to-cpp/test/component/active.fpp
Refactored and improved existing code	Simplified some list operations using List.concat Improved error messages for overflow hooks Refactored some repeated code in ComponentCppWriter	compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCppWriter.scala compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentInputPorts.scala compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentCommands.scala

---

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

[git-greetings[bot]]

PR Details of @2lambda123 in nasa-fpp :	OPEN	CLOSED	TOTAL
1	4	5

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

64 files out of 178 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[penify-dev[bot]]

Failed to generate code suggestions for PR

[codeautopilot[bot]]

Your organization has reached the subscribed usage limit. You can upgrade your account by purchasing a subscription at Stripe payment link

_Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect._ Current plan usage: 117.00% **Have feedback or need help?** [Discord](https://discord.gg/r72ykfvyx7) [Documentation](https://docs.codeautopilot.com/) [support@codeautopilot.com](mailto:support@codeautopilot.com)