2lambda123 / pytorch-serve

Apache License 2.0
0 stars 0 forks source link

Revert "open github issue on regression failure (#2248)" #12

Closed 2lambda123 closed 8 months ago

2lambda123 commented 8 months ago

Description

In this pull request, changes have been made to the GitHub Actions workflows for regression tests on CPU and GPU environments. The section responsible for opening an issue on failure has been removed from both workflows.

Summary by CodeRabbit

performance-testing-bot[bot] commented 8 months ago

Unable to locate .performanceTestingBot config file

cr-gpt[bot] commented 8 months ago

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

code-companion-ai[bot] commented 8 months ago

Processing PR updates...

git-greetings[bot] commented 8 months ago

Thanks @2lambda123 for opening this PR!

For COLLABORATOR only :

quine-bot[bot] commented 8 months ago

👋 Figuring out if a PR is useful is hard, hopefully this will help.

  • @2lambda123 has been on GitHub since 2019 and in that time has had 1869 public PRs merged
  • Don't you recognize them? They've been here before 🎉
  • Here's a good example of their work: HeyGenClone
  • From looking at their profile, they seem to be good with Shell and Java.

Their most recently public accepted PR is: https://github.com/2lambda123/pytorch-serve/pull/11

code-companion-ai[bot] commented 8 months ago

Description has been updated!

git-greetings[bot] commented 8 months ago
PR Details of @2lambda123 in pytorch-serve : OPEN CLOSED TOTAL
11 1 12
coderabbitai[bot] commented 8 months ago

Walkthrough

The recent modification simplifies the error handling in the continuous integration workflows by eliminating the steps that automatically opened issues upon test failures during scheduled runs. This change affects both CPU and GPU regression test workflows, streamlining the process and possibly shifting the responsibility of issue tracking to developers or different mechanisms.

Changes

Files Change Summary
.github/workflows/regression_tests_cpu.yml Removed automatic issue creation on failure
.github/workflows/regression_tests_gpu.yml Removed automatic issue creation on failure

🐇✨
In the realm of code where rabbits dare to hop,
Changes were made, unnecessary steps, chop, chop!
No more issues from the sky, automatically drop.
Now, we leap and bound, without a stop,
Celebrating the workflows that just won't flop.
🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
codeautopilot[bot] commented 8 months ago

PR summary

The Pull Request reverts a previous commit that added a feature to automatically open a GitHub issue when a regression test fails during a scheduled run. The reverted feature was implemented in both CPU and GPU regression test workflows. The removal of this feature means that failed regression tests will no longer automatically create issues, and manual monitoring or an alternative method will be needed to track and address regressions.

Suggestion

If the automatic issue creation was causing problems (e.g., spamming with too many issues, creating issues for flaky tests, etc.), it might be beneficial to refine the conditions under which an issue is created. For example, issues could be created only after a test has failed consecutively several times, or only for certain critical tests. Alternatively, a different notification system could be implemented, such as sending alerts to a dedicated Slack channel or email list, to reduce noise on the GitHub issues page.

codesyncapp[bot] commented 8 months ago

Check out the playback for this Pull Request here.