search

2nd-Layer / cardano-core-integration-testing

Integration Testing for Cardano Node and associated tooling
GNU Affero General Public License v3.0
1 stars 0 forks source link

[oS] Missing Hackage dependencies for Cardano Wallet backend #9

Open mark-stopka opened 3 years ago

mark-stopka commented 3 years ago

Following Hackage packages needs to be added to enable build and testing of Cardano Wallet backend:

Open Items:

mark-stopka commented 3 years ago

@hasufell, would you be able to provide any clarity on following open items related to cardano-wallet?

hasufell commented 3 years ago

Is it possible to require code-page only for Windows build of cardano-wallet-launcher?

Why? Win32 dependency is conditional in code-page.

cardano-wallet-core as per relevant cabal.project file uses IOG fork of persistent, while GitHub indicates that it is nothing but behind upstream, investigate why own fork is used, and if it can be replaced by upstream which is being actively maintained...

I've raised that issue before internally, because it creates other problems too, when integrating with our own ecosystem (such as cardano-db-sync). But I don't think this has high priority @KtorZ

mark-stopka commented 3 years ago

@hasufell, thanks for reply, @KtorZ, is there some list of needed modifications to add ability to use upstream version of peristent? Again, we got the budget and resources to do the work if we know what needs to be done...

KtorZ commented 3 years ago

More details here: https://github.com/input-output-hk/cardano-wallet/issues/1551

mark-stopka commented 3 years ago

@mimi1vx can you add the Hackage dependencies, or should I import them directly into the devel repo? New version of cardano-wallet is also out today so I am working on version bump-up automation script...

mimi1vx commented 3 years ago

+- all in ghc-8.10.x 😄