2ndQuadrant / pglogical

Logical Replication extension for PostgreSQL 15, 14, 13, 12, 11, 10, 9.6, 9.5, 9.4 (Postgres), providing much faster replication than Slony, Bucardo or Londiste, as well as cross-version upgrades.
http://2ndquadrant.com/en/resources/pglogical/
Other
987 stars 153 forks source link

Don't use !indisvalid indexes for conflict resolution. #436

Closed nmisch closed 3 months ago

nmisch commented 1 year ago

When reading !indisready indexes, their structural defects may elicit low-level errors, as seen in the new test coverage. While we must skip those, !indisvalid indexes don't have that problem and could be better than no index. Nonetheless, follow the server's infer_arbiter_indexes() in skipping !indisvalid indexes.

The test change complicates an existing test rather than setting up a new one. That saves a bit of test code and runtime. If you're prefer greater separation, let me know.