search

2ndtlmining / Fluxnode

Fluxnode Website
https://fluxnode.app.runonflux.io/
5 stars 6 forks source link

Fusion Fee bug #85

Closed 2ndtlmining closed 1 year ago

2ndtlmining commented 1 year ago

Problem description

We ran into an issue with the website completely not launching when we received a NULL value for one of the fees:

https://fusion.runonflux.io/fees

image

Resulting in website breaking a bit:

image

image

Proposed Fix

Although we should not be receiving NULL value, we should still render the site with no value in if we can.

victorquanlam commented 1 year ago

Possible solution:

  1. o.fusion_fee?.toFixed(2);// do something with result, which will be undefined if o.fusion_fee is null or undefined
  2. .concat(o.fusion_fee ? o.fusion_fee.toFixed(2): "0", "Fusion Fee")
2ndtlmining commented 1 year ago

Thanks mate. Yeah ended up fixing it in March forgot to close it up :) Thanks for looking btw ended up doing this so similar to your option 2:

image @victorquanlam

2ndtlmining commented 1 year ago

Ended up fixing with:

image