search

2ndtlmining / Fluxnode

Fluxnode Website
https://fluxnode.app.runonflux.io/
5 stars 6 forks source link

Score visibility #92

Closed 2ndtlmining closed 1 year ago

2ndtlmining commented 1 year ago

Problem Statement

Flux team is now performing Enterprise scores next to nodes. Like to provide node operators this information so they can see what their score per node is and then total score.

Requirements

  1. Display Enterprise Score in Node Overview screen
  2. Display Wallet total score as tooltip
  3. Tooltip for score in Node Overview

API

The API that contains information is here: https://api.runonflux.io/apps/enterprisenodes

Calculations

  1. Tooltip Calculation: There is only 1 calculation and that will be for the tooltip on the wallet. What we are looking for is a sum of all the "Score" against that wallet. Thus sum Score against the searched wallet in the API.

  2. Node Overview: UPNP nodes will not be listed in the API, thus if there is a search for them they will not be found in the API, thus need to put a 0 against them. So to make it simple if the node is not found in the API response just put 0.

UI

  1. Tooltip that shows the sum that is mentioned above in calculations: image

  2. Score added to Node Overview: Score tab should be added to Node overview screen showing the number received from API image

  3. Score Tooltip: We should display a Tooltip for the new column Score in the Node overview: Can put this as tooltip: "Enterprise score is an aggregated score taking maturity, node tier, identity and collateral into account". UPNP nodes are not considered thus have 0."

Testing

  1. Wallets: t3c4EfxLoXXSRZCRnPRF3RpjPi9mBzF5yoJ or t1cWqrpvhcGimwGYGRv2xoro3W87WZYzoVH
  2. Test wallet with and without UPNP as indicated above, also use the Demo function to see if that still works with the new column.
2ndtlmining commented 1 year ago

Thanks @Usman34266 adding score to the Node Overview Grid:

image

Tested also that UPNP is 0 which worked perfectly:

image

Couple small things if we could update:

  1. Could not test the tooltip as the header section is disabled by default for some reason
  2. Any chance we can move the score to the second last column in between Uptime and Apps for the Default configuration please?
image
2ndtlmining commented 1 year ago

Deployed and tested working well