add support for UNIQUE to be on par with master.

2shady4u / godot-sqlite

GDExtension wrapper for SQLite (Godot 4.x+)

MIT License

895 stars 79 forks source link

add support for UNIQUE to be on par with master. #100

Closed Dfred closed 1 year ago

2shady4u commented 1 year ago

Hi @Dfred!

Thanks for your contribution! I noticed that the README.md as found on the gd-extension-branch is out-of-date when compared to the version found on the master-branch and thus it might be good idea to synchronize them.

I've added some preliminary review comments that you can implement, but I'll have to wait until I have some time to properly review all the changes... apologies for that inconvenience.

Dfred commented 1 year ago

Good point, I'll merge the changes on README.md and review the comments. Thanks for the good work on Godot-SQLite !

Dfred commented 1 year ago

@2shady4u from what I could review, the changes in README.md are all changes I introduced, more precisely about:

the unique key (this PR topic)
how to currently get the lib from the gd-extension branch (using GitHub Actions & Artifacts, and building manually the debug version; see also issue #95).

I admit it might be confusing - thus bad practice - to add both in a single PR..