search

2shady4u / godot-sqlite

GDExtension wrapper for SQLite (Godot 4.x+)
MIT License
973 stars 83 forks source link

Add default value to select_rows columns array #108

Closed DamienBlack closed 2 years ago

DamienBlack commented 2 years ago

When selecting rows, it seems like a common usage is to just select all of them. However, sending in the value ["*"] is unintuitive and might not cross peoples mind.

Here I add a default value of ["*"] in the select_rows function so that the columns value can just be omitted to select all coulumns.

2shady4u commented 2 years ago

Hi @DamienBlack! Does this actually work? Cause I remember that, already a while ago, default arguments weren't implemented in godot-cpp :sweat_smile:

This functionality would be extremely nice to have.

DamienBlack commented 2 years ago

Sorry, I haven't made a build pipeline yet, so these changes aren't actually tested.

Fell free to deny the pull request if you want to wait until it has been built and tested. I'm not sure if that's something I'm going to get around to anytime soon.

2shady4u commented 2 years ago

You can easily test if the build succeeds by adding your branch's name to the relevant build pipeline.

For example for the .github/workflows/windows_builds.yml-file you just have to replace following line: 

branches: [ master, main ]

With the following:

branches: [ master, main, select_rows_default ]

And, after pushing this commit on your own branch (select_rows_default in this case), Github actions will automatically attempt to build the code.

DamienBlack commented 2 years ago

You are correct, this is not working. Sorry about that, I thought I had something similar in one of my own repositories, so I thought this was a real simple change. However, I forgot there was a workaround of an in-between function to handle the case with a default argument. I can see if I can implement something similar here later.