search

2shady4u / godot-sqlite

GDExtension wrapper for SQLite (Godot 4.x+)
MIT License
975 stars 83 forks source link

Add new functions for backup/restore. #130

Closed cridenour closed 1 year ago

cridenour commented 1 year ago

Useful for saving/loading to :memory: rather than using save files on the disk.

Didn't put a ton of thought into the API regarding errors, so there are probably some improvements we could make there. Been running on beta 12 in production, but could use some testing on rc5+.

2shady4u commented 1 year ago

Hi @cridenour

I finally found some time to take a look at the backup and restore functionality that you have implemented here. I've implemented the same functionality in https://github.com/2shady4u/godot-sqlite/tree/add-backup to avoid any merge conflicts (and with some minor modifications).

cridenour commented 1 year ago

Nice - that looks much nicer than my quick and dirty version.

On a separate note - I've been looking at moving my DB code to a module as managing GDExtension (while building with double precision specifically) is a huge hassle.

If I do, is that something you would be interested in having as a separate branch (similar to how GodotSteam does it)? I understand not wanting the hassle of having two branches to maintain.

2shady4u commented 1 year ago

Hello @cridenour

While implementing this SQLite wrapper as a module certainly interests me, I don't seem to have the necessary time available to maintain such a thing. I'll get back to you soon with some proposals.

Closing this PR as it has been superseded by 78695c7