Make query_result a typed array to counter GDScript being strict on array types.

2shady4u / godot-sqlite

GDExtension wrapper for SQLite (Godot 4.x+)

MIT License

850 stars 76 forks source link

Make query_result a typed array to counter GDScript being strict on array types. #135

Closed cridenour closed 1 year ago

cridenour commented 1 year ago

During my upgrade to 4.0-stable I realized anywhere I relied on getting an Array[Dictionary] from SQLite was no longer possible due to the strict array checking adding during the last beta.

If you were less strict in your code (aka asking for just an Array) this should still work.

2shady4u commented 1 year ago

Hi @cridenour

Thank you for your contribution 😄 I haven't tried out the new typed arrays in Godot 4.0 so I didn't know this was going to be an issue.

Going through the code, it seems that there are other places at which we might be able to apply this stricter typing. However, I don't think there's that much benefit to implementing this atm :) (low priority imo)