2shady4u / godot-sqlite

GDExtension wrapper for SQLite (Godot 4.x+)
MIT License
850 stars 76 forks source link

Reuse godot-cpp build actions #167

Open Ughuuu opened 5 months ago

Ughuuu commented 5 months ago

I have been recently reusing this action/workflow(hope to merge it at some point in godot-cpp-template if possible):

https://github.com/Ughuuu/godot-cpp-template/blob/add-more-stuff/options-to-build/.github/workflows/builds.yml

The basic idea is to build everything and sign for macos using a reusable action

Here is it in action(I ended up creating a file per build type, but aside for that it reuses build from that repo):

https://github.com/V-Sekai/godot-whisper/blob/main/.github/workflows/build_linux.yml

2shady4u commented 4 months ago

Hello @Ughuuu,

The "sign" part of this action seems to be quite useful, but I think it is something that is best implemented on the side of godot-cpp.

Regarding the matrix part of the "builds.yml"-file that you linked. I don't see how this matrix is more versatile/better than the dynamic system I have already implemented in this repository?

Ughuuu commented 4 months ago

Best thing would be you wouldnt have to maintain it, if it goes into godot-cpp repo.