search

2sic / 2sxc

DNN + 2sxc = #DNNCMS - This tool helps web designers and developers prepare great looking content in DNN (DotNetNuke). It's like mixing DNN with Umbraco and Drupal :)
http://2sxc.org
MIT License
145 stars 39 forks source link

Setting app icon / template icon via content type and template settings respectively has no effect #2926

Closed ajplopez closed 1 year ago

ajplopez commented 1 year ago

I'm submitting a ...
[x] bug report

...about [x] admin experience UI

Current behavior

If you try to set an app icon or template icon (used in the app chooser toaster tiles) via their respective settings dialogs, it doesn't update the tiles in the chooser. It seems the only way to get app-icon.png and _template.png icons to work is to upload them directly to the folder.

Expected behavior

Admin users should be able to drag and drop app-icon.png and _template-name.png directly to the edit modals to set the preview tile image.

Instructions to Reproduce the Problem For app-icon, go to a content type and click it's edit pencil. Under "More Settings like Icon, Notes, etc" add an icon.

For template icon, go to Views > View Configuration of a template, and toggle "Use Custom Icon" and drag and drop an icon here.

Why change the behavior?

Seems like a bug or its misconfigured. If it's working in some ways but needs a certain naming scheme, that should be updated in the help text.

Your environment

Anything you would like to add Jeremy tested this in the latest version and it is still a problem.

iJungleboy commented 1 year ago

The appicon.png is a convention, that cannot be changed as of now. I believe there's also no place in the UI to change this.

The template/view should be configurable...let me check...

jeremy-farrance commented 1 year ago

I just tried it on 2sxc v14.12.00 (just upgraded. DNN is v9.10.02) and I was not able to set the Icon for the View via the UI. I also cleared the cache and then even recycled the app-pool, closed and reopened the browser. Can't get my image to show up. I am pretty sure this worked a few months back, I remember doing it on one project and being very happy the feature was added. Cheers!! image

ajplopez commented 1 year ago

What is this Icon for? Screenshot 2022-11-10 at 1 32 23 PM

iJungleboy commented 1 year ago

@ajplopez On one hand drop should work...I will look into it.

But I actually urge you to use [App:Path]/somepath/file.png instead because that way the file remains in the app folder and is included on export import. See also https://docs.2sxc.org/basics/app/icons.html

ajplopez commented 1 year ago

Ah ok! Will do.

iJungleboy commented 1 year ago

I found the cause and fixed it.

I also added warnings and encouragements to the UI to push people in the right direction ;)