search

2sic / 2sxc

DNN + 2sxc = #DNNCMS - This tool helps web designers and developers prepare great looking content in DNN (DotNetNuke). It's like mixing DNN with Umbraco and Drupal :)
http://2sxc.org
MIT License
145 stars 39 forks source link

Update RenderSpecificLockManager to use AsyncKeyedLock #3363

Closed MarkCiliaVincenti closed 4 months ago

MarkCiliaVincenti commented 4 months ago

This will clean up the dictionary (avoids a slow memory leak) while using pooling to further reduce memory allocations.

iJungleboy commented 4 months ago

@MarkCiliaVincenti thanks for this, it looks much shorter and nicer.

@tvatavuk could you check? I have no idea what the original code does and if the replacement is suitable.

iJungleboy commented 4 months ago

@tvatavuk Thanks for the analysis.

@MarkCiliaVincenti we are very strict when adding new dependencies, as the side effects can be very far reaching.

Because of this I think it's better not to incorporate this change.

MarkCiliaVincenti commented 3 months ago

That's OK but @tvatavuk please note that AsyncKeyedLock has absolutely no compatibility issues with .NET 8; in fact the tests are written in .NET 8.