search

2sic / 2sxc

DNN + 2sxc = #DNNCMS - This tool helps web designers and developers prepare great looking content in DNN (DotNetNuke). It's like mixing DNN with Umbraco and Drupal :)
http://2sxc.org
MIT License
145 stars 40 forks source link

Image Presentation Settings bug (2sxc v18.00.00, Content v17.7.1) #3446

Open skarpik opened 3 months ago

skarpik commented 3 months ago

I'm submitting a

[x] bug report => search github for a similar issue before submitting

...about

[x] edit experience / UI

Current Behavior / Expected Behavior

In the Image presentation settings picker, the default values for "Shows the title in the lightbox" and "Shows the title as imagelegend" are false contrary to the on-screen instructions. The default should be that the caption appears by default without having to explicitly set these values to "true".

Default setting should show caption (but it doesn't):

Screenshot 2024-07-13 233802

To make the caption appear, both switches must be explicitly set to "true":

Screenshot 2024-07-13 234825

The behaviour is contrary to how past versions worked (specifically 2sxc v16.07.00 with Content v16.00.00) and it is contrary to the on-screen instructions.

Instructions to Reproduce the Problem

  1. Create a new DNN v9.13.3 website.
  2. Install 2sxc v18.00.00
  3. Create a page with an Image Content object (for instance, 3 images across)
  4. Add photo to the new image object and set the caption.
  5. The caption (as a legend or in the lightbox) does not appear by default (but it should).

Your environment

skarpik commented 1 month ago

The bug reported with 2sxc v18.00.00 and Content v17.7.1 still exists in 2sxc v18.01.00 and Content v17.7.3.

For the default setting, we should see both the title ("Giant Panda") in the lightbox and the title as image legend but we don't.

Default Settings:

Screenshot 2024-09-27 005123

Screenshot showing missing title text:

Screenshot 2024-09-27 005157

We can make the title ("Giant Panda") appear by explicitly setting the switches as below:

Screenshot 2024-09-27 005242

The result is as expected:

Screenshot 2024-09-27 005333

Conclusion - it appears that the default setting for the title switches if false rather than true (as the screen instructions state).

iJungleboy commented 3 weeks ago

Ok, I get it.

The problem is that we introduced new features so that just about every image could have a lightbox (or not).

The Content-App was created way before this feature, and tried to provide it on specific content-types only.

Now the settings on the content-app are kind of conflicting/misleading with the settings on the image itself.

We'll try to sync this again, but of course the existing content-app as they are won't change because of this.