search

2sic / app-news

A standard news / announcements app
MIT License
5 stars 0 forks source link

News app destroys Xcillion menu formatting #10

Open TopCat6 opened 3 years ago

TopCat6 commented 3 years ago

I'm submitting a ...

[x] bug report => search github for a similar issue before submitting

...about [x] DNN parts

Current behavior

After adding News - Pro 3.1 (v. 03.01.04) App to a page, the page's main menu gets messed up and moved. Expected behavior

Adding News App to page should not affect the page's menu. Minimal reproduction of the problem with instructions

Create a page with Xcillion skin showing menu at top right. Add 2sxc 11.11.04 App module to page. Choose News app for the module (News - Pro 3.1 (v. 03.01.04)). Accept default view. Refresh the page. Page menu is now top left in a column instead of top right in a row.

Screenshot of menu using News App (problem): image

Screenshot of menu after changing app to blu imp image gallery (normal): image

What is the motivation / use case for changing the behavior?

Reporting apparent bug. Please tell us about your environment:

Windows 10

Anything you would like to add

iJungleboy commented 3 years ago

Hi @TopCat6 we would love to help you, but we need more information to efficiently use our (free) time.

We don't use Xcillion and there are so many Themes / Skins out there (some of them poorly implemented), that we cannot test against all or even guarantee that our initial styling is already perfect for that.

We would need to know what styles are causing this and what would need to be fixed, because it's also possible that Xcillion implements Bootstrap badly - in which case it's maybe not an issue of this app.

BTW: A very common cause for this can also be that your skin may be missing the koi.json, in which case the news App may end up loading Bootstrap-files it doesn't need to. So before doing anything else, I would check that. See also https://connect-koi.net/css-frameworks

TopCat6 commented 3 years ago

Thanks @iJungleboy, I was using Xcillion because it comes with DNN, so I thought it would be a good one to test with. I checked and it does have a koi.json file that says it uses bs3:

"default": {
        "cssFramework": "bs3"
    }

I suppose this could be a bug in the Xcillion skin. If so, I should raise the issue there. Any insight from you would be helpful. I did try changing to Porto skin from Mandeeps and that worked fine, but I would like to resolve the issue with the Xcillion skin. Thanks. BTW, when it is displaying the page for "Article Not Found" the menu displays properly.

iJungleboy commented 3 years ago

@TopCat6 Thanks for the feedback.

Since we don't use it, we won't prioritize this. If you can find out what rule(s) cause the problem etc. we can fix it, but we cannot invest the time to research and fix this.