2sic / dnn-theme-bootstrap3-instant

A clean, prepared bootstrap3 skin for DNN (DotNetNuke), ready to make awesomeness - ideally combined with bootstrap content-templates.
MIT License
7 stars 2 forks source link

Mobile menu doee show just first level items #10

Open mangiove opened 7 years ago

mangiove commented 7 years ago

Hello, I was just giving a try to this and it seems that in mobile menù it does only show enabled/disablet node of first level menu

https://snag.gy/rbk5RU.jpg As you can see in screen it does show disabled nodes without childrens

iJungleboy commented 7 years ago

thanks for already using this :). I'm surprised to already have feedback because I haven't blogged about it yet :).

The node-settings of what the menu does are DDR-Menu settings in the skin (standard DNN stuff), this is configurable. Are you aware of this?

mangiove commented 7 years ago

I just like too see what you guys are doing so I'm following a few things here on github ;)

In my case I have got 2 disabled node, each with 2/3 chilldren... I know that it is configurable, and this should be the reference guide http://www.dnnsoftware.com/wiki/ddrmenu-reference-guide

In InstatB3 skin the mobile menu is by default configured to go 6 levels down, if i'm not wrong

<dnn:MENU MenuStyle="nav/main-mobile" NodeSelector="*,0,6" runat="server" />

and looking at template.cshtml with should render menu using razor it seems to not get children


@if (node.Enabled) {
            <a target="@(node.Target)" href="@node.Url">@node.Text</a>
    } else {
        @node.Text
        }
        @if(node.Breadcrumb)
         {
        @RenderNodes(node.Children)
         }

I could be wrong, thanks for support :)

iJungleboy commented 7 years ago

I believe you are correct - in 90% of our designs we only use 2 levels of navigation, as we try to reduce the amount of pages for the user UX and tend to use content-navigation (tiles) http://2sxc.org/en/apps/app/tiles-with-icons-for-bootstrap-dnn or collapsible accordions http://2sxc.org/en/apps/app/accordion-for-collapsible-sections instead.

If you feel that this would be a valuable enhancement, you can update it and push it back :).

mangiove commented 7 years ago

Thanks you! Tiles and accordion are cool but for my purpose I prefer to modify the menu module.

Just about now i modified it so it renders inactive nodes childrens

<li @classString>
    @if (node.Enabled) {
        <a target="@(node.Target)" href="@node.Url">@node.Text</a>
    } else {
        <span>@node.Text</span>
        @RenderNodes(node.Children)
    }
       @if(node.Breadcrumb)
        {
        @RenderNodes(node.Children)
        }
</li>

Then it would be nice to add some css and js to make like an accordion... Il give it a try as soon as I can :)

iJungleboy commented 7 years ago

Cool :)

We'll review how to integrate it - in case the inactive may have been on purpose