fix knobs glitching midi

2xAA / genmdm-editor

A web-based interface for genMDM and Mega Drive MIDI Interface, MIDI controllers for the Sega Mega Drive/Genesis.

https://2xaa.github.io/genmdm-editor/

MIT License

39 stars 6 forks source link

fix knobs glitching midi #177

Closed hex-spell closed 1 year ago

hex-spell commented 1 year ago

All Submissions:

[ x] This fixes #176
[ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x ] Have you lint your code locally before submission? (either with yarn run lint or using git hooks)

The fix

Basically I throttle the rate at which the midi CC messages are sent. I've set the rate to 30ms, but we could add an input in the ui to change it (if necessary)

hex-spell commented 1 year ago

don't merge this yet, I'll change the throttle to debounce and move the rate limiting to the MDMDial component

hex-spell commented 1 year ago

closing, I made a better fix for this