search

2xsaiko / rswires

Redstone wires
MIT License
5 stars 6 forks source link

Crash when breaking wires which exist horizontally and vertically #23

Open KyGost opened 3 years ago

KyGost commented 3 years ago

Very repeatable. Whenever breaking wires which are connected on a wall and a floor/roof surface, the client crashes. No effect on the server. Item is broken but no item form on ground when relaunching.

latest.log

2xsaiko commented 3 years ago

That crash is caused by another mod (Extra Enchants). I'm pretty sure this is not my fault, report it to them.

https://github.com/herb-mc/extra_enchants/blob/3d2e47e028f8e3244707a8ee73d58a7d39945db4/src/main/java/com/herb_mc/extra_enchants/mixin/BlockMixin.java#L42

KyGost commented 3 years ago

Oh woah, good find. Very curious that such a mod as that interferes with this mod specifically in this way.

Will check in there, thanks.

Closing for now. Will indevour to update here with either a confirmation of cause or reopen.

KyGost commented 3 years ago

Wait-- actually-- looking at that code, what is it that makes you think that is/should cause issues? @2xsaiko

KyGost commented 3 years ago

Oh, I managed not to look at the client side log for this crash, very silly of me. Though, looking at it with the context of the stack trace, sure that is the place where the error is occuring but this seems (from my observation) to be uniquely tied to the instance initally described in this issue (with RSWires). Is it possible RSWires is passing a null parameter?

I'll look through code on both sides and see if I see anything.

Reopening for now.

KyGost commented 3 years ago

I'm thinking something is awry with this line: https://github.com/2xsaiko/hctm-base/blob/f44553b982b4e87508277a509f03389284397e59/src/main/kotlin/common/block/BaseWire.kt#L111

Either something weird about giving a copy or something weird about params maybe.

KyGost commented 3 years ago

AH! Could it be because we're sending a client form player and a server form player is expected or something? https://github.com/2xsaiko/hctm-base/blob/265712a5718a0d7739cd3cc8b70238882123a50d/src/main/java/net/dblsaiko/hctm/mixin/MixinClientPlayerInteractionManager.java#L38