search

3-Round-Stones / callimachus

Callimachus is a highly scalable platform for creating and running data-driven websites
Other
95 stars 24 forks source link

"Home folder" Link in Breadcrumbs Mislabeled #189

Closed prototypo closed 9 years ago

prototypo commented 9 years ago

The "Home folder" link in the breadcrumbs is mislabeled. It currently goes to the site's home page. The label should be changed to reflect this or its location should change.

As an admin, I almost always prefer to have it resolve to the home folder, but unauthenticated users won't always be able to go there.

The "best" solution would be to resolve this link to the home folder if the user is currently authenticated and to the home page otherwise. Maybe just change the link to read "Home" in such a case?

catch-point commented 9 years ago

Why would you say it is mislabelled? By default the text is "localhost:8080" and the href is "http://localhost:8080/". All breadcrumbs (of folders) currently resolve to the index target of the folder. Are you suggesting this should be changed, or that the left most breadcrumb be handled differently?

I am a little concerned this would be inconsistent: all websites I can recall that I have used with breadcrumbs have the left most breadcrumb going to the root path. I believe that is expected from users when using breadcrumbs.

Perhaps it would be better to extend the folder view's secondary breadcrumbs to show more then just the parent folder? Those links already go to directly to the parent folder's view page.

prototypo commented 9 years ago

It is mislabeled because it reads "Home folder" but almost never resolves to a folder. That's why I suggested that it might change to just read "Home".

catch-point commented 9 years ago

The only way to get a label of "Home folder" on a 1.4.0-rc system, would be to install a early version (<1.0?) and upgrade it to 1.4.0-rc. The origin is labelled on install and is not modified on upgrade. By default the origin label is its authority.

prototypo commented 9 years ago

Ah, OK. I was in fact looking at a system that had been upgraded for years (wiki.3rs).