3-manifolds / Sage_macOS

SageMath as a macOS application bundle.
152 stars 15 forks source link

Resize icon #47

Closed teunzwart closed 6 months ago

teunzwart commented 1 year ago

Currently the icon for SageMath is somewhat larger than those of other apps (see attached screenshot). Would it be possible to slightly resize the icon so that its size is the same?

Screenshot 2022-11-05 at 17 04 22
culler commented 1 year ago

Thanks. I will look into this. I am reluctant to do a release just to adjust the icon size, but if I figure out how to do it I will replace the icon in the next release.

teunzwart commented 1 year ago

Thanks. Absolutely no rush

culler commented 1 year ago

Unfortunately this is not as simple as it might seem. When I made the icon I took some care to try to make it be the right size. So I was a little surprised by your screenshot, which I assumed was a screenshot of the dock. However, here are two screenshots of my docks, one from Big Sur and one from Monterey. The icon appears to be the right size. I also made careful measurements in the Finder icon view of my Applications folder, and the SageMath icon is the same size as the other icons and the space between the icon and the name is larger than in your screenshot. So I guess I would need a lot more detail about what is the exact context where you see the SageMath icon as being larger than others. I am not able to find a context where that happens.

DockShot1 DockShot2

teunzwart commented 1 year ago

How strange. I see it everywhere (Dock, LaunchPad, Finder). I'm running macOS 13.0 Ventura, maybe that's causing something weird to happen.

culler commented 6 months ago

I finally figured this out. First I discovered that he icon appeared with normal size on normal monitors but it appeared slightly larger on retina screens. The problem turned out to be a bug in the script I used to generate the .icns file. A .icns file is generated from 10 .png images, 5 for normal screens and 5 for retina screens. The 256x256@2x image for retina screens should be 512x512. My script was making it 256x256. Once I corrected that the icon was the correct size on both normal and retina screens. This will be fixed in the 10.3 release which will happen soon. So I am closing this ticket.