search

3-manifolds / SnapPy

SnapPy is a package for studying the topology and geometry of 3-manifolds, with a focus on hyperbolic structures. It is based on the SnapPea kernel written by Jeff Weeks.
https://snappy.computop.org/
84 stars 39 forks source link

use ruff to auto-fix many little details #121

Open fchapoton opened 9 months ago

fchapoton commented 9 months ago

this was scripted using ruff --fix --select=... for various codes.

This is fixing or rather modernizing many little details.

fchapoton commented 7 months ago

ping ? is this diff too large ? only simple changes, but maybe too many of them..

fchapoton commented 3 months ago

Sorry that this has bitrotted. Should I resolve the conflict ?

fchapoton commented 1 month ago

I have fixed the conflict, so please have a look if you can.

fchapoton commented 1 month ago

I have now double-checked carefuly all the changes.

culler commented 1 month ago

Even though we are no longer using Togl, I am not sure we are ready to delete it. There is no other source for that code. TkGL is still under development and we sometimes need to compare with the Togl code.

I could see moving Togl into the dev directory. But I don't think we should throw it all away.

NathanDunfield commented 1 month ago

I could see moving Togl into the dev directory. But I don't think we should throw it all away.

This PR does not touch the Togl directory. @unhyperbolic removed it in cd03de5.

culler commented 1 month ago

OK. I guess we can always recover it from an old commit anyway, so it doesn't really matter.

On Fri, Aug 16, 2024 at 9:49 AM Nathan Dunfield @.***> wrote:

I could see moving Togl into the dev directory. But I don't think we should throw it all away.

This PR does not touch the Togl directory. @unhyperbolic https://github.com/unhyperbolic removed it in cd03de5 https://github.com/3-manifolds/SnapPy/commit/cd03de5047a5bbe526396392227ee6fe4ca55899 .

— Reply to this email directly, view it on GitHub https://github.com/3-manifolds/SnapPy/pull/121#issuecomment-2293652257, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ6CP62PQBCPZUJWHUXHDLZRYGPXAVCNFSM6AAAAABA7QM46OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTGY2TEMRVG4 . You are receiving this because you commented.Message ID: @.***>

fchapoton commented 2 weeks ago

so this can be merged, right ?