search

3-manifolds / SnapPy

SnapPy is a package for studying the topology and geometry of 3-manifolds, with a focus on hyperbolic structures. It is based on the SnapPea kernel written by Jeff Weeks.
https://snappy.computop.org/
89 stars 41 forks source link

App: Error when opening python scripts that contain multiline functions #86

Closed NathanDunfield closed 1 year ago

NathanDunfield commented 1 year ago

Using File -> Open with on a file containing exactly:

def foo(x):
    a = x + 1
    return x

results in 

In[14]:     return x
  Input In [14]
    return x
    ^
SyntaxError: 'return' outside function
culler commented 1 year ago

I think this may be fixed in my latest commit (36cdc23).

NathanDunfield commented 1 year ago

Agreed, closed by 36cdc23713ad14a82266ad3ca7a8c897b48d81f9.

fchapoton commented 1 year ago

so the issue can be closed ?

culler commented 1 year ago

Yes.

fchapoton commented 1 year ago

Thanks. Do you have any time to have a look at my pull request ?