search

3-manifolds / SnapPy

SnapPy is a package for studying the topology and geometry of 3-manifolds, with a focus on hyperbolic structures. It is based on the SnapPea kernel written by Jeff Weeks.
https://snappy.computop.org/
87 stars 41 forks source link

test no longer for sage 9.1, add test for sage 9.8 #89

Closed fchapoton closed 1 year ago

fchapoton commented 1 year ago

Let us see if everything is fine with the latest sage.

Sage 9.1 is too old now.

fchapoton commented 1 year ago

sadly, sage 9.8 is not yet available on docker hub

NathanDunfield commented 1 year ago

@fchapoton First, many thanks for getting updated SageMath docker images created. As I followed that thread in sage-devel, I added 9.8 and 10.0 in 2bcf50ba6c9998d. Is ghcr.io/sagemath now the canonical location for these images?

fchapoton commented 1 year ago

hello, it seems you wrongly added the non-existing 9.10 instead of 10.0. Concerning the location, I would suggest to stick to dockerhub so my branch here ismaybe notso pertinent

NathanDunfield commented 1 year ago

Thanks for catching the nonexistent 9.10 issue, I feel like the CI should have raised an error there but it didn't. I have corrected to 10.0, so will close this ticket.

NathanDunfield commented 1 year ago

Ugh, I spoke too soon. I added 10.0, but GH actions "rounds" this to 10 and then sagemath/sagemath:10 does not exist.

NathanDunfield commented 1 year ago

Ugh, I spoke too soon. I added 10.0, but GH actions "rounds" this to 10 and then sagemath/sagemath:10 does not exist.

I solved this problem after a fashion by referring to 10.0 as latest.