search

3-manifolds / Spherogram

Spherogram is a Python module for dealing with the kind of planar diagrams that arise in 3-dimensional topology, such as link and Heegaard diagrams. It a component of the larger SnapPy project.
https://snappy.math.uic.edu/spherogram.html
19 stars 8 forks source link

add check for E221,E222,E227,E228 to the linter and extend it to dev/ #53

Closed fchapoton closed 1 year ago

fchapoton commented 1 year ago

this is

NathanDunfield commented 1 year ago

Looks like these errors are from building the the binary extension FXrays for Python 3.12, not your changes. But we should get everything working with Python 3.12 first to be sure, see #112.

culler commented 1 year ago

I think I have fixed FXRays. With Cython 3.0 the except clause apparently needs to be included when declaring a function pointer.

On Sun, Aug 13, 2023 at 1:52 PM Nathan Dunfield @.***> wrote:

Looks like these errors are from building the the binary extension FXrays https://github.com/3-manifolds/FXrays for Python 3.12, not your changes. But we should get everything working with Python 3.12 first to be sure, see #112 https://github.com/3-manifolds/SnapPy/issues/112.

— Reply to this email directly, view it on GitHub https://github.com/3-manifolds/Spherogram/pull/53#issuecomment-1676435708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ6CP3KFZ4DUYDQEHAWUV3XVEO5VANCNFSM6AAAAAA3OQRPVY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fchapoton commented 1 year ago

so it this now ready to merge ?

NathanDunfield commented 1 year ago

so it this now ready to merge ?

Probably. I think we've updated all the dependencies of spherogram to support Python 3.12, so try running the CI again. If t's all green, I'll merge.