301-Redirection / DBC

An online system for creating custom DOTA 2 bot scripts.
4 stars 1 forks source link

Home page improvements 239 #240

Closed Kwood22 closed 6 years ago

Kwood22 commented 6 years ago

Feel free to give opinions and suggestions.

Kwood22 commented 6 years ago

I have made changes to responsiveness as well as made the text left-align

steichert commented 6 years ago

Looks much better! The only other thing is there isn't much spacing between the buttons, and the title looks a bit off-centre compared to the rest of the text.

byronantak commented 6 years ago

Looks much better! The only other thing is there isn't much spacing between the buttons, and the title looks a bit off-centre compared to the rest of the text.

Maybe posting a screenshot could help explain the situation better?

byronantak commented 6 years ago

Kyle, since you are making changes to the front-end, can I ask that you add the Linux Steam route to the walkthrough page? Apparently, it's "~/.steam/steam/SteamApps/common" but I cannot say for sure

Reference https://askubuntu.com/questions/227502/where-are-steam-games-installed

steichert commented 6 years ago

screenshot 2018-10-15 at 18 05 13

byronantak commented 6 years ago

I have a problem... The heroes images don't load on my pc

byronantak commented 6 years ago

I have a problem... The heroes images don't load on my pc

I would have been nice to know that I had to remigrate and rescrape... :sweat:

byronantak commented 6 years ago

But I have a strange issue. A popover appears above an item, but also in the top left corner of the screen too...

Kwood22 commented 6 years ago

@SpellBreakerZA I cannot seem to replicate your popover issue, I have added the linux path to the tutorial page

byronantak commented 6 years ago

I am working on some other aspect of the system currently and cannot recreate it myself. I think that I hovered over a bought item and then over the items in the selection list

Kwood22 commented 6 years ago

@SpellBreakerZA I tried what you suggested. I still cannot replicate it :\

I cannot replicate it again either :sweat_smile:, I hope it was a once off error

byronantak commented 6 years ago

In the read me section of the bot config heroes tab, let the users know that they have to have 5 bots selected else there will be empty slots...

byronantak commented 6 years ago

In fact the game crashes if they have less than 5 heroes, so we need to enforce it on the front-end, if possible

byronantak commented 6 years ago

Is there a Linux and mac version of the install script? Do you provide a checksum?

Kwood22 commented 6 years ago

@SpellBreakerZA There are Windows, mac and Linux installer scripts, Linux and Mac work. Need to test the windows version.

byronantak commented 6 years ago

Can I merge this pull request? Everybody approved. So there are no grievances? I figured that Jeffrey would since he was the last to approve