30x / project-management

Tasks not specific to a given project, exploratory stuff and project management
0 stars 0 forks source link

Reconsider whether lack of routing keys should mean open season #154

Closed mpnally closed 8 years ago

mpnally commented 8 years ago

Noah and I discovered that we have been running production with no routing keys. Presumably we didn't notice because the lack of keys causes things to work rather than to fail. Is that the best default?

whitlockjc commented 8 years ago

The original reason we didn't use routing keys was because of the sso-proxy not being able to work with enrober and/or kiln being in a different namespace. That's since been fixed and we've updated all environments to have routing keys.

mpnally commented 8 years ago

Makes sense. I think it should be possible to run without key protection, but I think we should consider making the default be the other way. Finding out that we were running production without security because of a simple oversight did not feel good.

On Tue, Sep 13, 2016 at 8:23 AM, Jeremy Whitlock notifications@github.com wrote:

The original reason we didn't use routing keys was because of the sso-proxy not being able to work with enrober and/or kiln being in a different namespace. That's since been fixed and we've updated all environments to have routing keys.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/30x/project-management/issues/154#issuecomment-246718565, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoA6h6CyhBsLs8tUebT-02Ri31MG1ieks5qpr_ygaJpZM4J2d4B .

Martin Nally, Apigee Engineering