search

31051995 / ardupilot-mega

Automatically exported from code.google.com/p/ardupilot-mega
0 stars 0 forks source link

Implement SendSer instead of Serial.print #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Switch telemetry to output on SendSer as Serial3.print
2. Switch telemetry to output on SendSerln as Serial3.println
3. Telemetry data not outputted on Serial3

What is the expected output? What do you see instead?
GCS_* uses Serial.print and Serial.println instead of SendSer and SendSerln

What version of the product are you using? On what operating system?
1.0.2 - n/a

Please provide any additional information below.

Original issue reported on code.google.com by blakekr...@gmail.com on 20 Aug 2010 at 2:14

GoogleCodeExporter commented 9 years ago 
Made the defines to SendSer, and a switched case so that either telem is 
outputted to USB or Port4 (Serial3....) for Ardupilot GCS only...

Proc not called in 1_0_2

All Debug goes to USB regardles and informs the user what its set to.

need the gurus to check before releasing...

Original comment by michealj...@gmail.com on 20 Aug 2010 at 5:16

GoogleCodeExporter commented 9 years ago

Original comment by jasonshort on 20 Aug 2010 at 11:54

GoogleCodeExporter commented 9 years ago 
Michael, I may need to kick this one to you! I don't want to get into this 
myself.

Original comment by jasonshort on 21 Aug 2010 at 4:51

GoogleCodeExporter commented 9 years ago 
Michael has written a new version of Fast Serial which will be included in the 
libraries. This is the version we will move forward with.

Original comment by jasonshort on 23 Aug 2010 at 5:03

GoogleCodeExporter commented 9 years ago 
SendSer seems to be rather unclearly defined -- with its current usage, it 
seems like it would be better-named SendTelem.  Along the same lines, could we 
also change all the other Serial.print commands to generic commands as well?  I 
would like to debug my APM in flight, so I'd like to configure all the 
debugging messages to be sent to Serial3 as well.  I'd suggest creating 
SendDebug and SendDebugln so that we can select the serial port for debugging 
as easily as we can select the serial port for telemetry.

Original comment by bjpcalt...@gmail.com on 8 Sep 2010 at 11:07

GoogleCodeExporter commented 9 years ago 
I also wondered about that as well. It would be nice to have all the 
Serial.print(ln) set to variables that can be setup in the config file. Like 
you said debug could also be useful over the telem port.

I also see "SendOSD" and "SendOSDln" for integrating Remzibi and others.

Original comment by blakekr...@gmail.com on 9 Sep 2010 at 3:15

GoogleCodeExporter commented 9 years ago 
This has been bodged with the changes made during the FastSerial integration.

Ultimately the GCS protocols will take a Stream* argument at construction or 
init time and use the standard methods rather than random macros.

Original comment by DrZip...@gmail.com on 14 Sep 2010 at 7:42

GoogleCodeExporter commented 9 years ago

Original comment by jasonshort on 17 Sep 2010 at 7:42