33cn / chain33

高度模块化, 遵循 KISS原则的区块链开发框架
https://chain.33.cn
BSD 3-Clause "New" or "Revised" License
726 stars 254 forks source link

Fix cli #1282

Closed libangzhu closed 1 year ago

libangzhu commented 1 year ago
  1. 调整wallet 钱包模块ProcSignRawTx 函数中手续费设置的问题,此bug 导致在ReqSignRawTx 不设置fee的时候,构造阶段的fee 被清零。
  2. 交易回执data 字段为nil 时,导致第三方库hardhat执行失败
codecov[bot] commented 1 year ago

Codecov Report

Base: 61.79% // Head: 61.76% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (7747c22) compared to base (f060723). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 7747c22 differs from pull request most recent head 313b326. Consider uploading reports for the commit 313b326 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1282 +/- ## ========================================== - Coverage 61.79% 61.76% -0.04% ========================================== Files 170 170 Lines 23629 23630 +1 ========================================== - Hits 14601 14594 -7 - Misses 7187 7192 +5 - Partials 1841 1844 +3 ``` | [Impacted Files](https://codecov.io/gh/33cn/chain33/pull/1282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [wallet/wallet\_proc.go](https://codecov.io/gh/33cn/chain33/pull/1282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-d2FsbGV0L3dhbGxldF9wcm9jLmdv) | `59.61% <100.00%> (-0.27%)` | :arrow_down: | | [blockchain/localdb.go](https://codecov.io/gh/33cn/chain33/pull/1282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmxvY2tjaGFpbi9sb2NhbGRiLmdv) | `81.48% <0.00%> (-2.78%)` | :arrow_down: | | [system/crypto/secp256k1eth/secp256k1eth.go](https://codecov.io/gh/33cn/chain33/pull/1282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3lzdGVtL2NyeXB0by9zZWNwMjU2azFldGgvc2VjcDI1NmsxZXRoLmdv) | `45.86% <0.00%> (-2.26%)` | :arrow_down: | | [queue/queue.go](https://codecov.io/gh/33cn/chain33/pull/1282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cXVldWUvcXVldWUuZ28=) | `72.16% <0.00%> (-1.04%)` | :arrow_down: | | [blockchain/blockstore.go](https://codecov.io/gh/33cn/chain33/pull/1282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YmxvY2tjaGFpbi9ibG9ja3N0b3JlLmdv) | `62.20% <0.00%> (ø)` | | | [p2p/event.go](https://codecov.io/gh/33cn/chain33/pull/1282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cDJwL2V2ZW50Lmdv) | `52.83% <0.00%> (+1.88%)` | :arrow_up: | | [system/crypto/sm2/utils.go](https://codecov.io/gh/33cn/chain33/pull/1282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3lzdGVtL2NyeXB0by9zbTIvdXRpbHMuZ28=) | `90.47% <0.00%> (+4.76%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

libangzhu commented 1 year ago

@bysomeone 帮我review 下

33cn commented 1 year ago

:tada: This PR is included in version 1.68.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: