33mestre / jsviz

Automatically exported from code.google.com/p/jsviz
0 stars 0 forks source link

Layouts overwrite existing window.onresize, document.onmousemove, and document.onmouseup handlers #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
SnowflakeLayout and ForceDirectedLayout replace the value of
document.resize rather than using appendEventListener / attachEvent to add
a listener.

Original issue reported on code.google.com by kyle.sch...@gmail.com on 7 Feb 2007 at 4:18

GoogleCodeExporter commented 9 years ago

Original comment by kyle.sch...@gmail.com on 7 Feb 2007 at 5:21

GoogleCodeExporter commented 9 years ago
In SnowflakeLayout.js and ForceDirectedLayout.js, "inline" event handler 
assignments
were used for window.onresize, document.onmousemove, and document.onmouseup. 
These
assignments wrote over any existing event handlers. Each of these have been 
updated
to use addEventListener or attachEvent where appropriate.

Further work may be warranted to ensure cross-browser support:
- http://dean.edwards.name/weblog/2005/10/add-event2/
- http://therealcrisp.xs4all.nl/upload/addEvent_dean.html

Original comment by kyle.sch...@gmail.com on 9 Feb 2007 at 7:20

GoogleCodeExporter commented 9 years ago

Original comment by kyle.sch...@gmail.com on 9 Feb 2007 at 7:21