34736384 / genshin-fps-unlock

unlocks the 60 fps cap
MIT License
2.8k stars 217 forks source link

Issue with VSync disabler after 4.2. #251

Closed RealistikDash closed 11 months ago

RealistikDash commented 1 year ago

From my brief experimentation after the release of 4.2, the FPS cap cannot exceed your main monitor's refresh rate. In short, the VSync disabler does not seem to be working correctly/at all (reproduced on multiple machines). This is likely the source of all of the confusion regarding 4.2 support, as not many people go beyond their refresh rate.

From my minimal testing, this seems to be as simple as updating the VSync signature, which seems to have gotten changed.

RahuX commented 1 year ago

If you're talking about the setting not disabling the in game V-Sync when enabled, while that is an issue, it's really just meant as a setting to automatically set the in game setting to "off" from what I understand. At least that was the case for me when I've tried the setting before.

So the desired result of "having v-sync set to off" should just be achievable by just changing it in game, regardless of if the setting is enabled or disabled in the unlocker.

Just to prove this, I did some testing myself. Unlocker has the "auto vsync disabled" setting disabled, in game vsync is disabled (and my testing shows this setting is saved upon restarting the game), and I set the FPS cap to 240. Went into my teapot to give the game as much headroom as possible to run over the 144hz refresh rate of my monitor. Overlay is from Special K.

image

As you can see, at least for me, the game renders past 144 FPS no problem. This implies that vsync is in fact disabled.

34736384 commented 11 months ago

Removed in new version, just turn off vsync manually