search

34736384 / genshin-fps-unlock

unlocks the 60 fps cap
MIT License
2.8k stars 217 forks source link

Fix support for linux on wine #408

Closed PancakeTAS closed 5 months ago

PancakeTAS commented 5 months ago

This is an odd one, but it appears that LoadLibraryEx at least in the current proton/wine version does not return a single long buffer and instead has some holes in it. I couldn't pinpoint where those holes where, but IsBadReadPtr is meant for exactly this purpose. With it in place the pattern search works again.

PancakeTAS commented 5 months ago

(this fixes #404)

ethanaobrien commented 5 months ago

Just wanted to chime in and say that I can confirm this patch works, built locally and works great! Thanks!

34736384 commented 5 months ago

IsBadReadPtr should not be used regardless, I will make an update shortly

PancakeTAS commented 5 months ago

IsBadReadPtr should not be used regardless, I will make an update shortly

what do you suggest?

34736384 commented 5 months ago

fixed on https://github.com/34736384/genshin-fps-unlock/commit/4485c6a2bcce4ff2f1f82284222ade14f967b581