350org / ak_intl_v3

ActionKit templateset
3 stars 1 forks source link

Custom page field to be able to edit contact email on "event_created" #428

Open rachelhbd opened 1 year ago

rachelhbd commented 1 year ago

Goal, user story, and/or definition of the problem

As a digital organiser, I would like to be able to amend the contact email shown on the modal that pops up after confirming an event, by event campaign

Additional context

This is editable in Event_created.html: https://act.350.org/admin/cms/template/20140/edit/

Image

We will need to wrap the default email address "events@350.org" in a custom page field to make it editable

The name of the custom page field should start be called "Events - Event contact email shown on confirmation popup" to follow the naming convention

Once done, also need to revert language string "event_created_text_p2" in EN and FR to events@350.org

This will be done when

People needed

WTR/Sukhada

rachelhbd commented 1 year ago

@sukhada realising I didn't tag you before! There will be a batch of event updates on stack for the next weeks (for July or 1st half Aug, some of them small like this and some bigger. The project theme is "Optimisation & testing - Events pages"

sukhada commented 1 year ago

@rachelhbd got it!

cjmabry commented 1 year ago

Getting an issue in QA where postal code shows up twice, unsure if related to this or another previously undiscovered bug. Digging further

Update: Having trouble reproducing this, will follow up separately.

cjmabry commented 1 year ago

QA Results

cjmabry commented 1 year ago

@sukhada flagging this comment before deploy:

Once done, also need to revert language string "event_created_text_p2" in EN and FR to events@350.org

Do you follow what that means?

cjmabry commented 1 year ago

@sukhada I'm actually seeing a bug here where I see two email addresses listed at this link - not sure if related to this ticket or another: https://act.350.org/cms/thanks/demo-event-campaign_create?action_id=28650571&akid=.4909671.KKyRUy&ar=1&email=chris%40withtheranks.com&rd=1&taf=1&template_set=350.org%20-%20International%20v3%20(Develop)

Image

sukhada commented 1 year ago

@cjmabry that's expected - we need to remove the hardcoded email string that's included in event_created_text_pt1 as mentioned in this PR.